fix(controlplane): fallback CAS downloads from invalid backends#3255
Open
waveywaves wants to merge 1 commit into
Open
fix(controlplane): fallback CAS downloads from invalid backends#3255waveywaves wants to merge 1 commit into
waveywaves wants to merge 1 commit into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 5 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
waveywaves
force-pushed
the
fix/cas-download-backend-fallback
branch
from
40beb87 to
c896cf4
Compare
Contributor
Author
|
Updated tests for Cubic's edge-case feedback: nil mapped backend, missing default, missing fallback, and invalid fallback. Validation: SKIP_INTEGRATION=true go test ./app/controlplane/pkg/biz -run TestCASBackend -count=1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3190
Tests
SKIP_INTEGRATION=true go test ./app/controlplane/pkg/biz -run TestCASBackend -count=1SKIP_INTEGRATION=true go test ./app/controlplane/internal/service -count=1SKIP_INTEGRATION=true go test ./app/controlplane/internal/service ./app/controlplane/cmd -run TestDoesNotExist -count=1git diff --check