Repository navigation
Flush disk buffer file writes before notifying readers - #19
Merged
Merged
Conversation
hiporox
marked this pull request as ready for review
November 19, 2026 02:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Await the underlying file write before publishing disk buffer progress and waking the reader. A single record could otherwise remain buffered until another write woke the reader again. Both normal flushes and oversized writes now wait for file visibility.
How did you test this PR?
Both new regression tests fail on v0.62.0 and pass with the fix. The vector-buffers suite passed 118 tests with two ignored. Scoped Clippy and rustfmt checks also passed. In 30 uncached end-to-end runs with a Unix socket source and an OTLP HTTP receiver, the patched binary consistently exported all three signals.
Does this PR include user facing changes?