The SQL lexer lives in the core as Smolquery.Sql, since two edges read SQL with it (PL-66) - #350
Merged
Conversation
chasers
added this pull request to stack #354
September 20, 2026 00:57
…d SQL with it (PL-66) SmolqueryPg.Sql was written for the Postgres edge. The ClickHouse edge has used it since T-478 and leans on it for everything T-481 added, so one edge depended on another for a module that is about neither. A pure move: lib/smolquery_pg/sql.ex to lib/smolquery/sql.ex, its test with it, and every alias. No function changes. The moduledoc now names both edges as users. Smolquery.Ddl still scans for itself. It did so because a service may not depend on an edge, which no longer stands in its way, but moving a parser on the query path onto another scanner is its own change, not part of a rename. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chasers
force-pushed
the
sql-lexer-to-core
branch
from
September 20, 2026 03:11
93583d9 to
399d017
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: The SQL lexer moves from the Postgres edge to the core, as
Smolquery.Sql. A pure move.Tracker: T-502. Plan PL-66. Stacked on #349 (T-481).
Why
What changed
lib/smolquery_pg/sql.ex→lib/smolquery/sql.ex.Watch out
Smolquery.Ddlstill has its own scanner. Moving a parser on the query path is its own change: T-503.How to review
git diff -Mshows it as one.Checks
mix precommitmix ci🤖 Generated with Claude Code