HyperDX's Search page, statement by statement, against real rows: the corpus is the test (T-495) - #355
Merged
chasers merged 1 commit intoSep 20, 2026
Conversation
chasers
added this pull request to stack #354
September 20, 2026 01:03
… corpus is the test (T-495) No container runs on the dev box, so what stands in for a real HyperDX is what it sends. test/support/fixtures/clickstack/hyperdx_search.json holds the statements verbatim from HyperDX's source (hyperdxio/hyperdx @ c42dda8), with the settings it puts in every URL and its HYPERDX_PARAM_<hash> names: system.settings, version(), DESCRIBE with Identifier parameters, system.tables, system.data_skipping_indices, the SharedMergeTree probe, the results table, the histogram, a search term, and field, existence and map-key filters. The integration test writes 120 rows into a production-wired node (Smolquery.Test.FullNode), sends each statement through the router with the FORMAT clause clickhouse-js appends, and asserts what HyperDX reads: meta names and types, data, rows. Every step crosses the whole edge — parameters, quoting, the rewrite, the emulated catalog, the macros, the formats — and the planner's hot tier. It passed as written, which is what the five layers under it were for. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chasers
force-pushed
the
t-495-hyperdx-search-corpus
branch
from
September 20, 2026 03:11
9300a83 to
bc699f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: HyperDX's Search page, statement by statement, now runs against real ingested rows in an integration test. The corpus is the test.
Tracker: T-495. Plan PL-66. Stacked on #353 (T-485, T-494).
Why
What changed
test/support/fixtures/clickstack/hyperdx_search.json: HyperDX's statements, verbatim from its source (hyperdxio/hyperdx @ c42dda8).test/smolquery_clickhouse/hyperdx_search_test.exs: runs them against a production-wired node.lib/change.What the fixture holds
system.settings,version(),DESCRIBE,system.tables,system.data_skipping_indices, theSharedMergeTreeprobeSELECT ... ORDER BY Timestamp DESC LIMIT {..:Int32} OFFSET {..:Int32}asJSONCompactEachRowWithNamesAndTypescount()by severity andtoStartOfInterval(...), the alias named three timeshasTokenterm; field, existence and map-key filtersparam_HYPERDX_PARAM_<hash>values.\nFORMAT <name>that clickhouse-js appends.How it works
Smolquery.Test.FullNode.metanames and types,data,rows.Watch out
:integration, so it runs in the Integration tests job, not the fast suite.Checks
mix precommitmix cimix test --include integration test/smolquery_clickhouse/hyperdx_search_test.exs🤖 Generated with Claude Code