Skip to content

async-std TcpStream impls BufRead w/ AsyncWrite #63

Description

@pinkforest

eed4f0b

So wrapping TcpStream with BufReader should work ?

Even if I wrap it to BufReader then it wants AsyncWrite too complicating setting stuff like async-native-tls up ?

I could implement my own type with those implemented but probably doc neeeds to be adjusted - it's not as straightforward now in combination with the types it's usually used as the doc points to direct use with TcpStream.

45 |                 let mut transport = SmtpTransport::new(client, reader).await?;                
   |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `AsyncWrite` is not implemented for `std::io::BufReader<TlsStream<async_std::net::TcpStream>>`

Repro: https://github.com/pinkforest/repro-async-std-async-smtp

For now I'm just using 0.8 as but got to refactor and port this stuff over off async-std probably

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions