feat: deploy filtermail.mtail and add gate on mtail_address, rule compile check - #1036
Merged
Merged
Conversation
Contributor
|
i am guessing this PR is now not useful as #1023 is closed? IF not, please open a new one. |
Contributor
Author
|
No, it was a longer standing issue to be closed, before the idea of merging came up. It just needs to deal with the fetching of the mtail file now that its not simply in this repo, I started looking into that today. |
j4n
force-pushed
the
j4n/filtermail-mtail-deploy
branch
2 times, most recently
from
August 25, 2026 16:45
6b1ecf5 to
5a0ed74
Compare
Contributor
Author
|
now reworked and ready for review, we can squash before merge :) |
j4n
force-pushed
the
j4n/filtermail-mtail-deploy
branch
from
August 25, 2026 16:52
5a0ed74 to
ed7babe
Compare
j4n
marked this pull request as ready for review
August 25, 2026 16:52
j-g00da
approved these changes
Aug 25, 2026
…l_address Deploy filtermail.mtail program along delivered_mail.mtail, fetched from upstream; for this, refactor download_executable to accept mode, so we can use it to upload non-binaries. refactor: make hashes (for uniformity) and mtail version (for use by mtail deployer) module constants. Additionally, gate both mtail programs on mtail_address being set.
Compile /etc/mtail before activate() restarts the service, to catch errors early.
j4n
force-pushed
the
j4n/filtermail-mtail-deploy
branch
from
August 26, 2026 09:41
ed7babe to
c724187
Compare
hpk42
reviewed
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits, pending on filtermail merge in #1023: