Modification on ITEMS and ITEM pages - #67
Minimaxpower wants to merge 2 commits into
Conversation
…mode sombre, upload manuel, badges poster/background
|
👀 Human review needed JustificationThis PR is a large change from an external contributor ( Security-relevant surface introduced in
A human should review the input validation, path handling, and outbound-fetch behavior of these new endpoints before merge. Reviewed commit 8574302 |
| # a timeout. It is only (re)computed when the "🔄 Vérifier les posters" button | ||
| # is used, or right after a download (a single, cheap, known-fresh update). | ||
| # computed_at stays None until the first manual check ever happens. | ||
| _ASSET_CACHE = { |
There was a problem hiding this comment.
This process-wide asset cache is not keyed by the current session's asset directory or Plex server, so one user's manual scan is reused for every later session. That makes the poster/background badges and missing_only filtering report results for the wrong asset tree whenever the asset directory changes or more than one server/user uses the app.
Severity: medium
🤖 Was this useful? React with 👍 or 👎
| filename = compute_asset_filename(item, ctx["art_type"], ctx["season"], ctx["episode"], ext) | ||
|
|
||
| try: | ||
| resp = requests.get(image_url, timeout=15) |
There was a problem hiding this comment.
The URL upload path fetches an arbitrary user-supplied URL server-side and writes the response, without bounding what the server can contact or how much data it accepts. If this Flask app is reachable beyond a trusted localhost, a request can make the server contact internal services or consume disk/network resources.
Severity: medium
🤖 Was this useful? React with 👍 or 👎
|
Btw there's few lines added in the templates that will show in french on the website |
Items : Added dark mode, new pagination, search bar, system that show if you already have a poster/background, filter to see only posterless content.
Item : more content in the page, new systems to add posters, link to imdb and plex pages of the item, item page now show which poster you already have selected on plex..