fix: Handle workspace restart when DWO restarts the pod before the restart command reaches the browser - #795
Open
RomanNikitenko wants to merge 1 commit into
Conversation
…start command reaches the browser When Restart from Local Devfile updates spec.template with significant changes (e.g. adding a project), the DevWorkspace Operator may restart the pod before the browser-side restartWorkspace command is invoked, causing the disconnection handler to show an unexpected workspace not running dialog instead of redirecting to the dashboard. Signal the browser before the K8s patch so the disconnection handler can redirect to the dashboard if the extension host dies. Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
Contributor
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-795-amd64 |
RomanNikitenko
marked this pull request as ready for review
August 21, 2026 09:49
RomanNikitenko
requested review from
azatsarynnyy,
rgrunber and
vitaliy-guliy
as code owners
August 21, 2026 09:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Backport of #794
What issues does this PR fix?
https://redhat.atlassian.net/browse/CRW-9559
How to test this PR?
1. Restart Workspace from Local Devfile for Empty Workspace use case
Editor ImagefieldEmpty WorkspaceF1=>Restart Workspace from Local DevfileExpected result:
Cannot reconnect. Please reload the window.dialog is not displayed.2. Restart Workspace from Local Devfile for NOT Empty Workspace use case
Editor Imagefieldhttps://github.com/RomanNikitenko/web-nodejs-samplein theGit repo URLfieldCreate & OpenF1=>Restart Workspace from Local DevfileExpected result:
Cannot reconnect. Please reload the window.dialog is not displayed.3. Restart Workspace command use case
Restart Workspacecommand is also affected by the current PR changesEditor ImagefieldF1=>Restart Workspacewhen the workspace is ready to useExpected result:
Cannot reconnect. Please reload the window.dialog is not displayed.4. Stop Workspace command use case
Stop Workspacecommand is also affected by the current PR changesEditor ImagefieldF1=>Stop Workspacewhen the workspace is ready to useExpected result:
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folder