Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The retry loop can continue after the timeout, leaving background attempts and timers active.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Adds retries for delayed npm package availability and updates related tooling, naming, coverage handling, dependencies, and CI workflows.
Changes:
- Adds bounded retries for
npm viewandnpm install. - Updates npm metadata handling and tests.
- Refreshes utilities, workflows, dependencies, and documentation.
| File | Summary |
|---|---|
src/validate-npm-package/validate-npm-package.ts |
Adds npm retry and timeout behavior. |
src/validate-npm-package/validate-npm-package.spec.ts |
Tests retry behavior. |
src/perform-bundle/perform-bundle.ts |
Renames metadata identifiers. |
src/github-api/index.ts |
Refactors comment and review APIs. |
src/github-api/index.spec.ts |
Updates environment cleanup. |
src/github-api/index-reviews.spec.ts |
Updates review helper tests. |
src/github-api/index-publish-comment.spec.ts |
Strengthens rejection assertions. |
src/coverage-reporter/utility.ts |
Renames coverage utilities. |
src/coverage-reporter/utility.spec.ts |
Updates utility tests. |
src/coverage-reporter/tabulate.ts |
Updates sorting and parameters. |
src/coverage-reporter/lcov.ts |
Refactors LCOV parsing. |
src/coverage-reporter/html.ts |
Simplifies HTML rendering. |
src/coverage-reporter/delete-old-comments.ts |
Clarifies completion state naming. |
src/coverage-reporter/coverage-reporter.ts |
Adds reusable file reading. |
src/coverage-reporter/comment.ts |
Reuses generated coverage tables. |
src/check-pr-reviews/check-pr-reviews.ts |
Uses renamed reviewer-count APIs. |
src/check-pr-reviews/check-pr-reviews.spec.ts |
Updates module mocking. |
src/check-label/check-label.ts |
Renames version validation APIs. |
src/check-label/check-label-compare-match-semver.spec.ts |
Updates validation tests. |
src/check-imports/package-lock-file-utility.ts |
Renames range-matching APIs. |
src/check-imports/package-lock-file-utility.spec.ts |
Updates utility tests. |
src/check-imports/check-imports.ts |
Uses renamed utilities. |
README.md |
Updates package metadata. |
package.json |
Updates dependencies, scripts, and engine requirements. |
LICENSE |
Updates the copyright year. |
.github/workflows/coverage.yml |
Splits base and PR coverage jobs. |
.github/workflows/codeql-analysis.yml |
Updates CodeQL actions. |
.github/workflows/ci.yml |
Updates CI matrices, actions, and concurrency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+61
to
+63
| } finally { | ||
| // timeout() does not cancel the retry loop, so kill any in-flight npm process and fail the remaining attempts | ||
| abortController.abort(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105