Node 24 - #32
Merged
Merged
Node 24#32
Conversation
carlansley
had a problem deploying
to
npm-publish
September 2, 2026 17:56 — with
GitHub Actions
Failure
|
Coverage after merging node24 into main will be
Coverage Report
|
||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
🟡 Changes recommended
The publish workflow’s npm publish steps have no authentication configured, which is likely to break release/beta publishing.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the package/tooling baseline to support newer Node runtimes as part of the “Node 24” upgrade, including dependency and CI/workflow adjustments.
Changes:
- Bumps package major version to 5.0.0, updates Node engine requirement, and upgrades devDependencies (notably
uuid). - Updates GitHub Actions workflows (CI matrix, coverage reporting, publish flow) to newer Node versions and consolidated publish behavior.
- Refreshes repository metadata/docs (copyright years, README/SECURITY wording).
File summaries
| File | Description |
|---|---|
| src/uuid-v5.ts | Copyright year update. |
| src/uuid-v5.spec.ts | Copyright year update. |
| src/index.ts | Copyright year update. |
| src/hash.ts | Copyright year update. |
| src/hash.spec.ts | Copyright year update. |
| SECURITY.md | Updates supported-version wording/table for v5+. |
| README.md | Copyright year update. |
| package.json | Major version bump, Node engine bump, script updates, dependency upgrades. |
| LICENSE.txt | Copyright year update and minor formatting. |
| .github/workflows/publish.yml | Consolidates release + PR beta publishing into one workflow and updates actions/node versions. |
| .github/workflows/publish-beta.yml | Removes separate beta publish workflow (now consolidated). |
| .github/workflows/coverage.yml | Splits base/pr coverage runs, uploads artifacts, and posts combined report. |
| .github/workflows/codeql-analysis.yml | Updates CodeQL action major version. |
| .github/workflows/ci.yml | Updates CI Node matrix and action versions. |
| .github/workflows/check-published-scheduled.yml | Updates checkout action and environment variable usage. |
Review details
Suppressed comments (1)
.github/workflows/publish.yml:59
- Same as the release publish: the beta publish step currently has no auth configured, so publishing to npm will likely fail. If the intent is to use GitHub OIDC, ensure provenance is enabled; otherwise pass
NODE_AUTH_TOKEN.
- name: Publish Beta
if: github.event_name == 'pull_request'
run: npm publish --tag beta
- Files reviewed: 15/16 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Beta Published - Install Command: |
lukebrdn
approved these changes
Sep 2, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31