Skip to content

Node 24 - #32

Merged
carlansley merged 1 commit into
mainfrom
node24
Sep 2, 2026
Merged

carlansley merged 1 commit into
mainfrom
node24

Conversation

@carlansley

Copy link
Copy Markdown
Contributor

Fixes #31

@carlansley carlansley self-assigned this Sep 2, 2026
Copilot AI lite review requested due to automatic review settings September 2, 2026 17:56
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Coverage after merging node24 into main will be

100.00% 0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   hash.spec.ts100%100%100%100%
   hash.ts100%100%100%100%
   uuid-v5.spec.ts100%100%100%100%
   uuid-v5.ts98.04%60%100%100%82–83

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The publish workflow’s npm publish steps have no authentication configured, which is likely to break release/beta publishing.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates the package/tooling baseline to support newer Node runtimes as part of the “Node 24” upgrade, including dependency and CI/workflow adjustments.

Changes:

  • Bumps package major version to 5.0.0, updates Node engine requirement, and upgrades devDependencies (notably uuid).
  • Updates GitHub Actions workflows (CI matrix, coverage reporting, publish flow) to newer Node versions and consolidated publish behavior.
  • Refreshes repository metadata/docs (copyright years, README/SECURITY wording).
File summaries
File Description
src/uuid-v5.ts Copyright year update.
src/uuid-v5.spec.ts Copyright year update.
src/index.ts Copyright year update.
src/hash.ts Copyright year update.
src/hash.spec.ts Copyright year update.
SECURITY.md Updates supported-version wording/table for v5+.
README.md Copyright year update.
package.json Major version bump, Node engine bump, script updates, dependency upgrades.
LICENSE.txt Copyright year update and minor formatting.
.github/workflows/publish.yml Consolidates release + PR beta publishing into one workflow and updates actions/node versions.
.github/workflows/publish-beta.yml Removes separate beta publish workflow (now consolidated).
.github/workflows/coverage.yml Splits base/pr coverage runs, uploads artifacts, and posts combined report.
.github/workflows/codeql-analysis.yml Updates CodeQL action major version.
.github/workflows/ci.yml Updates CI Node matrix and action versions.
.github/workflows/check-published-scheduled.yml Updates checkout action and environment variable usage.
Review details

Suppressed comments (1)

.github/workflows/publish.yml:59

  • Same as the release publish: the beta publish step currently has no auth configured, so publishing to npm will likely fail. If the intent is to use GitHub OIDC, ensure provenance is enabled; otherwise pass NODE_AUTH_TOKEN.
      - name: Publish Beta
        if: github.event_name == 'pull_request'
        run: npm publish --tag beta
  • Files reviewed: 15/16 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/publish.yml
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Beta Published - Install Command: npm install @checkdigit/hash@5.0.0-PR.32-b512

@carlansley
carlansley requested a review from lukebrdn September 2, 2026 18:10
@carlansley
carlansley merged commit c63246e into main Sep 2, 2026
12 of 15 checks passed
@carlansley
carlansley deleted the node24 branch September 2, 2026 19:47

This branch was successfully deployed

1 active deployment
npm-publish — c3fb511c Deployed Sep 2, 2026 by carlansley via Publish Beta #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to Node 24

3 participants