Update to OIDC publishing - #100
Merged
Merged
Conversation
carlansley
had a problem deploying
to
npm-publish
September 15, 2026 18:31 — with
GitHub Actions
Failure
There was a problem hiding this comment.
🟡 Changes recommended
Separate privileged publishing from pull-request tests and pin npm to tested versions.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates npm publishing to use OIDC trusted publishing while refreshing tooling and CI workflows.
Changes:
- Consolidates release and beta publishing.
- Updates dependencies, scripts, and lockfile.
- Modernizes ESLint, Node, npm, and CI setup.
- Expands published-bundle testing.
File summaries
| File | Summary |
|---|---|
package.json |
Updates version, tooling, scripts, and dependencies. |
package-lock.json |
Refreshes dependency lock data. |
eslint.config.mjs |
Removes unused import-plugin configuration. |
.github/workflows/publish.yml |
Adds OIDC-based release and beta publishing. |
.github/workflows/publish-beta.yml |
Removes the superseded beta workflow. |
.github/workflows/ci.yml |
Updates npm setup and CI installation. |
.github/workflows/check-published-scheduled.yml |
Updates Node/npm setup for scheduled checks. |
Review details
Suppressed comments (4)
.github/workflows/check-published-scheduled.yml:20
- Installing
npm@latestmakes the scheduled verification job non-reproducible and allows a future npm release to change registry or package-inspection behavior without a repository change. Pin npm to the tested version used by this project instead.
- name: Update npm
run: npm install --global npm@latest
.github/workflows/ci.yml:27
- Installing
npm@latestmakes CI depend on an unpinned external major version. A future npm release can stop supporting the Node 24 matrix or alter install behavior without a repository change; pin npm to the tested version used by this project instead.
- name: Update npm
run: npm install --global npm@latest
.github/workflows/ci.yml:56
- Installing
npm@latestmakes CI depend on an unpinned external major version. A future npm release can stop supporting the Node 24 matrix or alter install behavior without a repository change; pin npm to the tested version used by this project instead.
- name: Update npm
run: npm install --global npm@latest
.github/workflows/publish.yml:41
- Installing
npm@latestmakes the release authentication and publish behavior depend on an unpinned external major version. A future npm release can change trusted-publishing requirements or stop supporting the repository's Node 26 runtime without any repository change; pin npm to a tested version that meets the OIDC minimum instead.
- name: Update npm
run: npm install --global npm@latest
- Files reviewed: 6/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Beta Published - Install Command: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99