Skip to content

ci: authenticate Image push to quay.io with OIDC - #3309

Merged
tklauser merged 1 commit into
mainfrom
pr/tklauser/image-push-oidc
Sep 23, 2026
Merged

tklauser merged 1 commit into
mainfrom
pr/tklauser/image-push-oidc

Conversation

@tklauser

Copy link
Copy Markdown
Member

Follow upstream cilium/cilium workflow changes and use OIDC to authenticate CI to quay.io, instead of the static robot password. The GitHub token cannot be used as the registry password directly, so it is traded for a short lived robot token before the login.

@nbusseneau

Copy link
Copy Markdown
Member

Code LGTM, wonder why hostname was not working in testing.

@tklauser

Copy link
Copy Markdown
Member Author

Code LGTM, wonder why hostname was not working in testing.

I think @aanm still needs to make some changes. He'll ping me once they're done I can test this again. Moving to draft until then.

@tklauser
tklauser marked this pull request as draft September 22, 2026 15:46
Comment thread .github/workflows/images-dev.yaml Outdated
Comment thread .github/workflows/images-release.yaml Outdated
Comment thread .github/workflows/images-dev.yaml Outdated
@tklauser
tklauser force-pushed the pr/tklauser/image-push-oidc branch 2 times, most recently from 5bb720e to e379093 Compare September 23, 2026 09:04
@tklauser
tklauser requested a review from aanm September 23, 2026 09:04
@tklauser

Copy link
Copy Markdown
Member Author

@aanm copy&paste comments should be fixed now

Comment thread .github/workflows/images-release.yaml Outdated
@tklauser
tklauser force-pushed the pr/tklauser/image-push-oidc branch from e379093 to 3a20d33 Compare September 23, 2026 09:10
@tklauser
tklauser requested a review from aanm September 23, 2026 09:10
@tklauser
tklauser marked this pull request as ready for review September 23, 2026 09:10
Comment thread .github/workflows/images-dev.yaml Outdated

@aanm aanm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny nit

Comment thread .github/workflows/images-dev.yaml Outdated
Comment thread .github/workflows/images-release.yaml Outdated
Comment thread .github/workflows/images-dev.yaml
Comment thread .github/workflows/images-release.yaml
@tklauser
tklauser force-pushed the pr/tklauser/image-push-oidc branch from 982702a to 0df1d74 Compare September 23, 2026 14:23
Comment thread .github/workflows/images-dev.yaml Outdated
@maintainer-s-little-helper maintainer-s-little-helper Bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 23, 2026
Follow upstream cilium/cilium workflow changes and use OIDC to
authenticate CI to quay.io, instead of the static robot password. The
GitHub token cannot be used as the registry password directly, so it is
traded for a short lived robot token before the login.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser

Copy link
Copy Markdown
Member Author

Successful run: https://github.com/cilium/cilium-cli/actions/runs/35873886319

Dropping the test commit and amending the change requested here: #3309 (comment)

@tklauser
tklauser force-pushed the pr/tklauser/image-push-oidc branch from 0df1d74 to cf03edc Compare September 23, 2026 19:09
@tklauser
tklauser merged commit abeb517 into main Sep 23, 2026
7 of 8 checks passed
@tklauser
tklauser deleted the pr/tklauser/image-push-oidc branch September 23, 2026 19:36
hbjydev pushed a commit to hbjydev/phoebe that referenced this pull request Sep 28, 2026
… (#752)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [aqua:cilium/cilium-cli](https://github.com/cilium/cilium-cli) | tools | patch | `0.20.0` → `0.20.1` |

---

### Release Notes

<details>
<summary>cilium/cilium-cli (aqua:cilium/cilium-cli)</summary>

### [`v0.20.1`](https://github.com/cilium/cilium-cli/releases/tag/v0.20.1)

[Compare Source](cilium/cilium-cli@v0.20.0...v0.20.1)

#### What's Changed

- chore(deps): update docker.io/library/golang:1.27.0 docker digest to [`0ecdc2a`](cilium/cilium-cli@0ecdc2a) by [@&#8203;renovate](https://github.com/renovate)\[bot] in [#&#8203;3295](cilium/cilium-cli#3295)
- Update stable release to v0.20.0 by [@&#8203;tklauser](https://github.com/tklauser) in [#&#8203;3296](cilium/cilium-cli#3296)
- chore(deps): update softprops/action-gh-release digest to [`efb3536`](cilium/cilium-cli@efb3536) by [@&#8203;renovate](https://github.com/renovate)\[bot] in [#&#8203;3297](cilium/cilium-cli#3297)
- chore(deps): update dependency kubernetes-sigs/kind to v0.33.0 by [@&#8203;renovate](https://github.com/renovate)\[bot] in [#&#8203;3298](cilium/cilium-cli#3298)
- chore(deps): update golangci/golangci-lint docker tag to v2.13.2 by [@&#8203;renovate](https://github.com/renovate)\[bot] in [#&#8203;3299](cilium/cilium-cli#3299)
- chore(deps): update helm/kind-action action to v1.15.0 by [@&#8203;renovate](https://github.com/renovate)\[bot] in [#&#8203;3300](cilium/cilium-cli#3300)
- chore(deps): update go to v1.27.1 by [@&#8203;renovate](https://github.com/renovate)\[bot] in [#&#8203;3301](cilium/cilium-cli#3301)
- chore(deps): update go by [@&#8203;renovate](https://github.com/renovate)\[bot] in [#&#8203;3303](cilium/cilium-cli#3303)
- chore(deps): update gcr.io/distroless/static:latest docker digest to [`5813399`](cilium/cilium-cli@5813399) by [@&#8203;renovate](https://github.com/renovate)\[bot] in [#&#8203;3302](cilium/cilium-cli#3302)
- chore(deps): update all github action dependencies by [@&#8203;renovate](https://github.com/renovate)\[bot] in [#&#8203;3305](cilium/cilium-cli#3305)
- Prepare for v0.20.1 release by [@&#8203;tklauser](https://github.com/tklauser) in [#&#8203;3304](cilium/cilium-cli#3304)
- chore(deps): update cilium/cilium action to v1.20.2 by [@&#8203;renovate](https://github.com/renovate)\[bot] in [#&#8203;3306](cilium/cilium-cli#3306)
- chore(deps): update dependency cilium/cilium to v1.20.2 by [@&#8203;renovate](https://github.com/renovate)\[bot] in [#&#8203;3308](cilium/cilium-cli#3308)
- chore(deps): update docker/setup-buildx-action action to v4.4.1 by [@&#8203;renovate](https://github.com/renovate)\[bot] in [#&#8203;3307](cilium/cilium-cli#3307)
- ci: authenticate Image push to quay.io with OIDC by [@&#8203;tklauser](https://github.com/tklauser) in [#&#8203;3309](cilium/cilium-cli#3309)
- go.mod, vendor: update github.com/cilium/cilium to latest by [@&#8203;tklauser](https://github.com/tklauser) in [#&#8203;3310](cilium/cilium-cli#3310)

**Full Changelog**: <cilium/cilium-cli@v0.20.0...v0.20.1>

</details>

---

### Configuration

📅 **Schedule**: (in timezone Europe/London)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMTEuNCIsInVwZGF0ZWRJblZlciI6IjQ0LjExNS4xMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9wYXRjaCJdfQ==-->

Reviewed-on: https://git.hayden.moe/hayden/phoebe/pulls/752

This branch had an error being deployed

1 failed deployment
ci — cf03edce Deployed Sep 23, 2026 by tklauser via push #303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has passed all tests and received consensus from code owners to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants