Add an AI checkbox

[jsf9k]

🗣 Description

This pull request adds an AI checkbox to the pre-approval checklist.

💭 Motivation and context

This forces the pull request creator to indicate if AI was used to generate code, and if so attest that he or she understands the generated code and is comfortable answering questions about it.

🧪 Testing

All automated tests pass. I also viewed the pull request template and verified that it appears correct.

✅ Pre-approval checklist

• This PR has an informative and human-readable title.
• Changes are limited to a single goal - eschew scope creep!
• All relevant type-of-change labels have been added.
• I have read the CONTRIBUTING document.
• These code changes follow cisagov code standards.
• All new and existing tests pass.
• Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.

✅ Pre-merge checklist

• Finalize version.

✅ Post-merge checklist

• Create a release (necessary if and only if the version was bumped).

[dav3r]

I human-approve this addition! 🤖

[felddy]

I like it. But... what if it was generated by AI and I'm not comfortable explaining it?
Or if it was generated by AI, but I have no idea how it works, but am more than happy to talk about that.

I think this should either be separated into a bullet and a sub-bullet, or we update the contributing guide to enforce this relationship. Probably the former.

• AI was used to generate code in this PR (in part or in full).
  • I understand the generated code and can explain its functionality.
  • I am comfortable answering questions regarding its implementation.

I didn't want to have a single bullet under the first, since the nuns would find me and beat me. But seeing the "comfort" bullet makes me realize this probably should apply to any code in a PR regardless if AI generated it.

I'm going to go dig up some examples I've seen on other projects.

[felddy]

I like the idea of adding an AI label:

• Add UDP packet retry mechanism to udp_name_sync usermod wled/WLED#5873

We could auto apply it if the commit message had AI identifiers in it:

• https://github.com/korext/ai-attestation#supported-tools

More examples of PR templates with AI checkboxes:

• https://github.com/FlorianBruniaux/claude-code-ultimate-guide/blob/main/examples/config/PULL_REQUEST_TEMPLATE-ai.md

This has some cool ideas but is beyond adding checkboxes to the template. I think we should consider adding agent guidance that can help ensure the checkboxes are checked by humans:

• https://www.aibuilderclub.com/blog/reviewing-ai-generated-pull-requests

[jsf9k]

I like it. But... what if it was generated by AI and I'm not comfortable explaining it? Or if it was generated by AI, but I have no idea how it works, but am more than happy to talk about that.

I think this should either be separated into a bullet and a sub-bullet, or we update the contributing guide to enforce this relationship. Probably the former.

• AI was used to generate code in this PR (in part or in full).

  • I understand the generated code and can explain its functionality.
  • I am comfortable answering questions regarding its implementation.

I didn't want to have a single bullet under the first, since the nuns would find me and beat me. But seeing the "comfort" bullet makes me realize this probably should apply to any code in a PR regardless if AI generated it.

I'm going to go dig up some examples I've seen on other projects.

Please see commits 9c4793f and 945c1c4.

[jsf9k]

I like the idea of adding an AI label:

• Add UDP packet retry mechanism to udp_name_sync usermod wled/WLED#5873

Please see cisagov/skeleton-generic#289.

[felddy]

Very nice! Even better than I came up with.

[dav3r]

Good improvements! 👍 🤖