Skip to content

mod_env: Fix SetEnvFromFile read errors and quoted values - #5

Closed
cisbiceanu wants to merge 3 commits into
trunkfrom
fix-setenvfromfile
Closed

cisbiceanu wants to merge 3 commits into
trunkfrom
fix-setenvfromfile

Conversation

@cisbiceanu

Copy link
Copy Markdown
Owner

Reject non-EOF read failures with file and line diagnostics instead of silently ignoring the remaining entries.

Support single- and double-quoted values using SetEnv escaping rules. Preserve quoted whitespace and existing unquoted behavior, and reject malformed quoted entries.

Add regression tests and document the parsing rules.


  • This PR does not report or address a security vulnerability
    (see SECURITY.md and
    https://www.apache.org/security/#reporting-a-vulnerability).
  • Code follows the httpd style guide.
  • New log messages (level debug or higher) use an empty APLOGNO() tag;
    numbers are assigned by a committer at merge time (see docs/log-message-tags/README).
  • If the change is user-visible, a changes-entries/*.txt file is included,
    following the template in README.CHANGES (not needed otherwise).
  • Test cases based on pyhttpd are included where appropriate, in the
    test/modules/xxx directory matching the modules/xxx module source,
    or test/modules/core for core server changes. On Unix, verify these
    pass locally with e.g. make check-pytest PYTEST_DIRS=test/modules/xxx.

Reject non-EOF read failures with file and line diagnostics instead
of silently ignoring the remaining entries.

Support single- and double-quoted values using SetEnv escaping rules.
Preserve quoted whitespace and existing unquoted behavior, and reject
malformed quoted entries.

Add regression tests and document the parsing rules.
qabasel and others added 2 commits November 11, 2026 16:48
Add an optional Quoted argument to enable SetEnv-style quoted values.
Preserve literal quotes and backslashes when the argument is omitted,
and reject unsupported options.

Update the manual and expand regression coverage for both parsing modes
and option validation.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant