Skip to content

docs: fix 2 typos in comments #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Avicennasis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: fix 2 typos in comments #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/jit_preloader/active_record/associations/collection_association.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def load_target
# If we went through a JIT preload, then we will have attached another JitPreloader elsewhere.
JitPreloader::Preloader.attach(records) if records.any? && !jit_loaded && JitPreloader.globally_enabled?

# If the records were not pre_loaded
# If the records were not preloaded
records.each{ |record| record.jit_n_plus_one_tracking = true }

if !jit_loaded && owner.jit_n_plus_one_tracking
Expand Down
2 changes: 1 addition & 1 deletion lib/jit_preloader/preloader.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def jit_preload(associations)
# If you dump a ActiveRecord::Base object that has a jit_preloader instance variable
# you will also end up dumping all of the records the preloader has reference to.
# Imagine getting N objects from a query and dumping each one of those into a cache
# each object would dump N+1 objects which means you'll end up storing O(N^2) memory. Thats no good.
# each object would dump N+1 objects which means you'll end up storing O(N^2) memory. That's no good.
# So instead, we will just nullify the jit_preloader on load
def _dump(level)
""
Expand Down