Skip to content

Remove 'resolve' from ordered set - #76

Open
NoahTheDuke wants to merge 1 commit into
clj-commons:masterfrom
NoahTheDuke:nb/remove-resolve-from-ordered-set
Open

Remove 'resolve' from ordered set#76
NoahTheDuke wants to merge 1 commit into
clj-commons:masterfrom
NoahTheDuke:nb/remove-resolve-from-ordered-set

Conversation

@NoahTheDuke

@NoahTheDuke NoahTheDuke commented May 13, 2024

Copy link
Copy Markdown
Contributor

See #71.

clojure.core/hash-unordered-coll has been around since 1.6 and ordered only supports 1.10+ so there's no need to check for its existence anymore.

Comment thread src/flatland/ordered/set.clj
@lread

lread commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

@NoahTheDuke is this PR still relevant?

@NoahTheDuke

Copy link
Copy Markdown
Contributor Author

Who knows lol. I think removing resolve is good in either case, so I'll redo it.

@NoahTheDuke
NoahTheDuke force-pushed the nb/remove-resolve-from-ordered-set branch from 7357353 to 81e3979 Compare September 4, 2026 16:38
See [clj-commons#71](clj-commons#71).

`clojure.core/hash-unordered-coll` has been around since 1.6 and ordered only
supports 1.10+ so there's no need to check for its existence anymore.
@NoahTheDuke
NoahTheDuke force-pushed the nb/remove-resolve-from-ordered-set branch from 81e3979 to 88e8a63 Compare September 4, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants