Implement ITransientAssociative2 for OrderedMap - #97
Open
NoahTheDuke wants to merge 1 commit into
Open
Conversation
NoahTheDuke
force-pushed
the
nb/contains-and-find-in-transient-ordered-map
branch
from
September 4, 2026 15:22
6af9610 to
3e158b0
Compare
Collaborator
|
I'll not be so bold as to merge this one and wait for @danielcompton to review! @NoahTheDuke, you do have a merge conflict to address (I think I'm done with PRs for the time being!). |
NoahTheDuke
force-pushed
the
nb/contains-and-find-in-transient-ordered-map
branch
from
September 4, 2026 16:35
3e158b0 to
b5e40fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ITransientAssociative2 was introduced in Clojure 1.8 and ordered requires 1.10, so we're good to go.
Also switches finding methods to use a private
(Object.)fornot-found, instead of relying on the strange and potentially buggythisbehavior as noted in the comment.Closes #69