fix(code): make guided-manual-qa the single copy for Codex and Claude Code (ISS-11436) - #208
Merged
Merged
Conversation
- Fold in the session continuity rules: services stay under an owner
that survives tool calls and worker turns, and a resumed session
rechecks head, processes, listeners, data target and route
- Open the requested window before a UI checkpoint, verify its route,
then stop tool calls until the human responds
- Add the interactive window owner line and the service owner note to
the QA record template
- Name the launcher relative to the skill directory instead of
${CLAUDE_SKILL_DIR}, so Codex resolves it too
- Ship agents/openai.yaml for Codex display metadata
- Bump code to 1.15.1
Testing: ruff, pyright, pytest plugins/, guided-manual-qa typecheck,
vitest and rebuild (dist unchanged), claude plugin validate plugins/code
Risks: None identified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
guided-manual-qaexisted in two places:plugins/code/skills/guided-manual-qahere (added in #205, ISS-11436) and a local Codex skills copy it was ported from. The two drifted. The Codex copy picked up session continuity and checkpoint rules after the port, while this copy gained the tested TypeScript launcher and wording cleanups.This PR makes the plugin directory the single canonical copy, used by both Claude Code (through the installed
codeplugin) and Codex (which will load this directory through a symlink). Everything the Codex copy had that this one lacked is folded in, and the skill no longer depends on anything only one harness understands.What changed
Brought over from the Codex copy:
agents/openai.yamlso Codex keeps its display name, short description and default prompt.claude plugin validate plugins/codeoutput is identical before and after adding it, andclaude plugin validate plugins/code/skillspasses.Kept from this copy:
scripts/dist/launch-interactive-browser.mjslauncher. The Codex.cjslauncher is not brought over.Made portable:
SKILL.mdno longer uses${CLAUDE_SKILL_DIR}, which Codex does not expand. It names the launcher asscripts/dist/launch-interactive-browser.mjsrelative to the skill directory and tells the agent to resolve the absolute path from where it readSKILL.md, while running it from the repository root so Playwright still resolves from the repository under test.references/browser-state-fixtures.mduses the same placeholder.No merge conflicts: the Codex-side changes and this copy's changes touch different lines.
Versions
code1.15.0 -> 1.15.1 (skill wording, template lines, Codex metadata file)Testing
uv run ruff check .: cleanuv run pyright: 0 errorsuv run pytest plugins/: 2175 passed, 3 skippedtools/guided-manual-qa:npm run typecheck,npm test(40 passed),npm run build(committed bundle unchanged)node plugins/code/skills/guided-manual-qa/scripts/dist/launch-interactive-browser.mjs --helpprints usageclaude plugin validate plugins/code: passes, same warnings asmain