fix(server-nestjs): register SystemConfigModule to unblock system/plugins routes - #2436
Draft
shikanime wants to merge 1 commit into
Draft
fix(server-nestjs): register SystemConfigModule to unblock system/plugins routes#2436shikanime wants to merge 1 commit into
shikanime wants to merge 1 commit into
Conversation
shikanime
force-pushed
the
fix/system-config-module-registration
branch
2 times, most recently
from
August 7, 2026 13:20
1398d6d to
900ae61
Compare
…gins routes SystemConfigModule was implemented but never imported into MainModule, leaving GET/POST /api/v1/system/plugins as dead routes (404). Registers the module alongside SystemSettingsModule. Removes the orphan system-config-queries.utils.ts (unimported, duplicates inline select in system-config.service.ts). Updates MODULARISATION-CARTOGRAPHIE.md with corrected route paths and marks system/config as migrated. Resolves #2208 (dev-mode functional endpoints). Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio>
shikanime
force-pushed
the
fix/system-config-module-registration
branch
from
August 7, 2026 14:16
900ae61 to
5d788ab
Compare
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (43.70% Estimated after merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro: #2208
Quel est le comportement actuel ?
SystemConfigModule(qui déclareSystemConfigController, exposantGET/POST /api/v1/system/plugins) n'est pas importé dansMainModule: les routes renvoient404(routes mortes, non enregistrées).MODULARISATION-CARTOGRAPHIE.mddocumente des chemins obsolètes (GET /api/v1/admin/plugins-config,PUT /api/v1/admin/plugins-config) et la sectionsystem/confign'est pas marquée comme migrée.Quel est le nouveau comportement ?
SystemConfigModuleest ajouté auximportsdeMainModule(apps/server-nestjs/src/main.module.ts) : le contrôleur est instancié et les routesGET/POST /api/v1/system/pluginsrépondent correctement.MODULARISATION-CARTOGRAPHIE.md: chemins corrigés enGET /api/v1/system/plugins/POST /api/v1/system/plugins, sectionsystem/configmarquée✅ MIGRE.Cette PR introduit-elle un breaking change ?
Non.
Autres informations
PR de résorption de dette de modularisation (strangler) : le contrôleur et le contrat existaient déjà, seul l'enregistrement du module manquait. Aucune modification de contrat ni de schéma.