mirror_worker: remove undeployed state fallbacks - #294
Open
lukevalenta wants to merge 1 commit into
Open
lukevalenta wants to merge 1 commit into
lukevalenta wants to merge 1 commit into
Conversation
lukevalenta
requested review from
a team,
bwesterb,
cjpatton,
lbaquerofierro and
mendess
as code owners
September 22, 2026 20:09
lukevalenta
marked this pull request as draft
September 22, 2026 20:18
lukevalenta
changed the title
lukevalenta
force-pushed
the
lvalenta/validate-legacy-witness-retries
branch
from
September 22, 2026 20:20
850b20b to
e7050f3
Compare
lukevalenta
marked this pull request as ready for review
September 22, 2026 20:30
lukevalenta
force-pushed
the
lvalenta/validate-legacy-witness-retries
branch
from
September 22, 2026 20:35
e7050f3 to
14aaf20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mirror and witness state formats introduced by #288 and #289 have never been deployed, so no persisted records can predate the retry fingerprint or source checkpoint fields.
This removes compatibility code for those hypothetical records:
add-checkpointrequest matches the accepted request.Removing the size/hash/checkpoint-text fallback addresses #288 (comment): a retry can no longer bypass normal
old_sizeand consistency-proof validation through that path.