Inherit hibernation across Server subclasses - #417
Merged
Conversation
🦋 Changeset detectedLatest commit: 93888ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hono-party
partyfn
partyserver
partysocket
partysub
partysync
partytracks
partywhen
y-partyserver
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
hibernatethrough the server constructor chain, using the nearest explicitly configured value.partyserver.Root cause
PartyServer read
this.#ParentClass.options.hibernatedirectly. A child class that declared its own partialstatic optionsobject shadowed the hibernating base class object, leavinghibernateundefined. PartyServer then silently selected the in-memory connection manager.This is the underlying cause of cloudflare/agents#2012. Once this ships, cloudflare/agents#2022 can replace its pre-
super()compatibility workaround with the new PartyServer release.Reproduction
Before the fix, the regression connected through a child of a hibernating server whose own static options were empty.
ctx.getWebSockets()returned0, proving the socket had been accepted in memory. It returns1after the fix.Validation
npm run build -w partyservernpm run check