Skip to content

Add signature_version support to storage-cli S3 config templates - #688

Merged
johha merged 1 commit into
cloudfoundry:developfrom
ybykov-a9s:add-storage-cli-s3-signature-version
Sep 2, 2026
Merged

Add signature_version support to storage-cli S3 config templates#688
johha merged 1 commit into
cloudfoundry:developfrom
ybykov-a9s:add-storage-cli-s3-signature-version

Conversation

@ybykov-a9s

@ybykov-a9s ybykov-a9s commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

The storage-cli S3 client accepts an optional signature_version
parameter, but the connection_config sub-options were not being
extracted into the rendered storage_cli_config_*.json files, so the
value was silently dropped even when operators set it.

Add signature_version passthrough to all storage_cli_config_*.json.erb
templates in cloud_controller_ng, cloud_controller_worker,
cloud_controller_clock, cc_deployment_updater, and blobstore_benchmark,
and cover it in the corresponding storage_cli_config_jsons_spec.rb specs.

Github Copilot AI (Claude Sonnet 5) was used to identify all locations requiring changes
and to draft the PR message.

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the develop branch

  • I have run CF Acceptance Tests on bosh lite

@ybykov-a9s
ybykov-a9s force-pushed the add-storage-cli-s3-signature-version branch from ad53eae to 0a235e3 Compare September 1, 2026 14:35
@johha

johha commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Thank you @ybykov-a9s for the contribution. The changes look good overall.
As you're a new contributor to CAPI I'd like to mention our AI tooling policy. In case you used AI for this PR it would be great if you could briefly mention it in the PR description.

@ybykov-a9s

Copy link
Copy Markdown
Contributor Author

@johha Thank you for the remark. I updated the information regarding AI.

@johha johha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johha
johha merged commit 2054aa9 into cloudfoundry:develop Sep 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants