Add signature_version support to storage-cli S3 config templates - #688
Merged
johha merged 1 commit intoSep 2, 2026
Merged
Conversation
ybykov-a9s
force-pushed
the
add-storage-cli-s3-signature-version
branch
from
September 1, 2026 14:35
ad53eae to
0a235e3
Compare
Contributor
|
Thank you @ybykov-a9s for the contribution. The changes look good overall. |
Contributor
Author
|
@johha Thank you for the remark. I updated the information regarding AI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The storage-cli S3 client accepts an optional
signature_versionparameter, but the connection_config sub-options were not being
extracted into the rendered
storage_cli_config_*.jsonfiles, so thevalue was silently dropped even when operators set it.
Add
signature_versionpassthrough to allstorage_cli_config_*.json.erbtemplates in
cloud_controller_ng,cloud_controller_worker,cloud_controller_clock,cc_deployment_updater, andblobstore_benchmark,and cover it in the corresponding
storage_cli_config_jsons_spec.rbspecs.Github Copilot AI (Claude Sonnet 5) was used to identify all locations requiring changes
and to draft the PR message.
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite