Repository navigation
fix: use exact, case-insensitive CA name matching for signed certificate lookups - #1235
Merged
Merged
Conversation
findAllCertificateCredentialsByCaName looks up certificates by an exact CA name, so compare with = instead of LIKE, consistent with the other exact name lookups.
peterhaochen47
force-pushed
the
TNZGOV-15664-exact-match-ca-name
branch
from
November 16, 2026 23:05
9a1a7ff to
6175ef5
Compare
dlinsley
reviewed
Nov 17, 2026
Comment on lines
95
to
99
Contributor
There was a problem hiding this comment.
most likely an issue pre-dating this fix, this .remove(caName) is not case-insensitive. Could potentially not remove the originating CA from the list.
Member
Author
There was a problem hiding this comment.
good catch! it's unrelated to this PR, but we can address it along the way since its small, pushed an additional commit.
The CA name lookup is case-insensitive, but the CA itself was removed from the results with a case-sensitive match, so a CA name given in different casing could be listed among its own signed certificates.
dlinsley
approved these changes
Nov 17, 2026
dlinsley
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for adding tests as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findAllCertificateCredentialsByCaName looks up certificates by an exact CA name, so compare with = instead of LIKE, consistent with the other exact name lookups.