Skip to content

fix(deps): Update dependency eslint-plugin-unicorn to v68 #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 3 commits into from
Jul 1, 2026
Merged

fix(deps): Update dependency eslint-plugin-unicorn to v68 #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72a30cf
fix(deps): Update dependency eslint-plugin-unicorn to v68
cloudquery-ci[bot] Jul 1, 2026
a056098
fix: Disable new eslint-plugin-unicorn v68 rules and apply autofixes
erezrokah Jul 1, 2026
37c7a2e
Merge branch 'main' into renovate/major-eslint-packages
erezrokah Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,18 @@ export default tseslint.config(
'unicorn/no-null': 'off',
'unicorn/prevent-abbreviations': 'off',
'unicorn/consistent-function-scoping': 'off',
'unicorn/consistent-boolean-name': 'off',
'unicorn/prefer-private-class-fields': 'off',
'unicorn/max-nested-calls': 'off',
'unicorn/prefer-await': 'off',
'unicorn/no-break-in-nested-loop': 'off',
'unicorn/no-computed-property-existence-check': 'off',
'unicorn/prefer-number-coercion': 'off',
'unicorn/name-replacements': 'off',
'unicorn/require-array-sort-compare': 'off',
'unicorn/prefer-array-from-map': 'off',
'unicorn/prefer-math-constants': 'off',
'unicorn/prefer-number-is-safe-integer': 'off',
'n/no-missing-import': 'off',
'n/no-unsupported-features/node-builtins': 'off',
'import-x/no-named-as-default': 'off',
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"eslint-plugin-n": "^18.0.0",
"eslint-plugin-prettier": "^5.0.0",
"eslint-plugin-promise": "^7.0.0",
"eslint-plugin-unicorn": "^64.0.0",
"eslint-plugin-unicorn": "^68.0.0",
"eslint-plugin-unused-imports": "^4.0.0",
"typescript-eslint": "^8.0.0",
"prettier": "^3.0.1",
Expand Down
110 changes: 69 additions & 41 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/memdb/memdb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ export const newMemDBPlugin = (): Plugin => {
return Promise.resolve(pluginClient);
}
const parsedSpec = JSON.parse(spec) as Partial<Spec>;
const validSchema = validate(parsedSpec);
if (!validSchema) {
const isValidSchema = validate(parsedSpec);
if (!isValidSchema) {
const messages = validate.errors?.map((error) => error.message).join(', ');
return Promise.reject(new ValidationError(`Invalid spec: ${messages}`, { props: { spec } }));
}
Expand Down
4 changes: 2 additions & 2 deletions src/package/docker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ const buildDockerfile = async (
const supportedTargets = await pMap(
plugin.buildTargets(),
async ({ os, arch }) => {
const imageRepository = `docker.cloudquery.io/${plugin.team()}/${plugin.kind()}-${plugin.name()}`;
const imageTag = `${imageRepository}:${pluginVersion}-${os}-${arch}`;
const imageRepo = `docker.cloudquery.io/${plugin.team()}/${plugin.kind()}-${plugin.name()}`;
const imageTag = `${imageRepo}:${pluginVersion}-${os}-${arch}`;
const imageTar = `plugin-${plugin.name()}-${pluginVersion}-${os}-${arch}.tar`;
const imagePath = `${outputDirectory}/${imageTar}`;
logger.info(`Building docker image ${imageTag}`);
Expand Down
4 changes: 2 additions & 2 deletions src/plugin/serve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ export const createServeCommand = (plugin: Plugin) => {
if (!semverValid(pluginVersion)) {
throw new Error(`invalid plugin version: ${pluginVersion}`);
}
distDir = distDir || path.join(pluginDirectory, 'dist');
docsDir = docsDir || path.join(pluginDirectory, 'docs');
distDir ||= path.join(pluginDirectory, 'dist');
docsDir ||= path.join(pluginDirectory, 'docs');
await packageDocker({ logger, message, distDir, docsDir, pluginVersion, pluginDirectory, plugin });
},
)
Expand Down
Loading