Skip to content

chore: Resolve visual regression host from the PR head commit #5211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jperals merged 2 commits into from
Oct 30, 2026
+9 −2
Merged

chore: Resolve visual regression host from the PR head commit #5211

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2db96a6
chore: Resolve visual regression host from the PR head commit
jperals Oct 30, 2026
2dd1c5e
Merge branch 'main' into fix/visual-regression-pr-host
jperals Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/visual-regression.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,16 @@ jobs:
MAX_ATTEMPTS=10
DELAY=15

# Every PR deploys to the same environment, so filter by the commit under test.
if [ -z "$SHA" ]; then
echo "::error::No commit SHA provided; cannot resolve the PR deployment"
exit 1
fi

for attempt in $(seq 1 $MAX_ATTEMPTS); do
echo "Attempt ${attempt}/${MAX_ATTEMPTS}: looking for deployment with environment '${DEPLOY_ENV}'..."
echo "Attempt ${attempt}/${MAX_ATTEMPTS}: looking for deployment with environment '${DEPLOY_ENV}' and sha '${SHA}'..."
DEPLOY_ID=$(gh api \
"repos/${REPO}/deployments?environment=${DEPLOY_ENV}&per_page=5" \
"repos/${REPO}/deployments?environment=${DEPLOY_ENV}&sha=${SHA}&per_page=5" \
--jq '.[0].id // empty' 2>/dev/null || true)
NEW_URL=""
if [ -n "$DEPLOY_ID" ]; then
Expand All @@ -139,6 +145,7 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
REPO: ${{ github.repository }}
SHA: ${{ inputs.commit-sha }}

- name: Start baseline server
run: npx --yes serve --no-clipboard --listen 8080 pages/lib/static-visual-baseline &
Expand Down
Loading