Repository navigation
fix: Truncate long table header cell labels with an ellipsis - #5225
Draft
gethinwebster wants to merge 1 commit into
Draft
gethinwebster wants to merge 1 commit into
gethinwebster wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5225 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 1003 1003
Lines 32572 32572
Branches 12109 12110 +1
=======================================
Hits 31843 31843
+ Misses 723 684 -39
- Partials 6 45 +39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TableHeaderCellhad no handling for a label wider than its column. In grid layout, a long label spilled across the neighbouring header cell, and the neighbour's background painted over it, so the label looked cropped.Header labels now truncate with an ellipsis, using the same rule as
TableBodyCellcontent (nowrap,overflow: hidden,text-overflow: ellipsison the content wrapper). Cells withdisablePaddings, such as a select-all control column, are left alone, as they are for body cells.In visual refresh, the first column's content sits flush with the cell's start edge, so the new clip would cut off part of a focus ring on a control in that cell. The first cell's content wrapper now gets a start padding the size of the focus outline gutter and an equal negative start margin. The text stays in the same place, and the clip edge moves out far enough for the focus ring.
The existing
Tableis unaffected: it renders its header cells without the content wrapper these rules target.Related links, issue #, if available: n/a
How has this been tested?
src/table-header-cell/__integ__/truncation.test.ts) on a new dev page,table-root/header-truncation, with columns narrower than their labels:main's styles (no ellipsis; no room for the ring) and pass with this change.table-rootintegration tests and thetable,table-rootandtable-header-cellunit tests pass.Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.