You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore: Adds internal style api v2 to radio group - #5226
Adds the internal Style API v2 to Radio group: item forwards to RadioButton.control and applies to every radio in items. The group root has no slot; it only lays out the radios.
Changes outside the component: the @property registration of the radio control tokens moves from radio-button/styles.scss to the shared internal/components/radio-button/styles.scss, next to the carrier, so Radio group (and Tiles and Table selection, which render the same control) load it without the public Radio button. Generated docs and mixins are unchanged.
The style-docs snapshot and the VR registration of the dev page follow in one PR for all components.
Tracker section: P3d34KdbCd6o.
Related links, issue #, if available: n/a
How has this been tested?
Unit tests for the forward, dev page radio-group/style-api-v2, build and lint green.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
Changes include appropriate documentation updates.
Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
Changes do not include unsupported browser features, see CONTRIBUTING.md.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.76%. Comparing base (8a3001d) to head (9867269). ⚠️ Report is 1 commits behind head on main.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Two convention issues remain: the duplicated plans fixture should be shared, and the internal style class names prop should use the __ prefix while preserving the public entry point.
The dev-page convention requires reusing fixtures rather than duplicating them. This is the same plans fixture as pages/radio-button/style-api-v2.page.tsx:19-23; please extract it into a shared fixture and reuse it so the two style API examples do not drift.
Prefix the internal styleClassNames prop with __
src/radio-group/internal.tsx:24
The component-structure convention requires props that are absent from the public RadioGroupProps to use the __ prefix, so their internal status is clear. Please name this internal prop __styleClassNames and adapt the wrapper to map the existing styleClassNames input to it, preserving the Style API entry point.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The internal-only prop in src/radio-group/internal.tsx lacks the required __ prefix; it should be renamed to __styleClassNames while preserving the wrapper’s styleClassNames entry point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the internal Style API v2 to Radio group:
itemforwards to RadioButton.control and applies to every radio initems. The group root has no slot; it only lays out the radios.Changes outside the component: the
@propertyregistration of the radio control tokens moves fromradio-button/styles.scssto the sharedinternal/components/radio-button/styles.scss, next to the carrier, so Radio group (and Tiles and Table selection, which render the same control) load it without the public Radio button. Generated docs and mixins are unchanged.The style-docs snapshot and the VR registration of the dev page follow in one PR for all components.
Tracker section: P3d34KdbCd6o.
Related links, issue #, if available: n/a
How has this been tested?
Unit tests for the forward, dev page
radio-group/style-api-v2, build and lint green.Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.