Repository navigation
feat(no-ticket): link update notices to the Cloudsmith changelog - #609
Draft
cloudsmith-iduffy wants to merge 1 commit into
Draft
cloudsmith-iduffy wants to merge 1 commit into
cloudsmith-iduffy wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the changes directing update links to version-specific Cloudsmith changelog entries.
No open issues 🎉
What changed in this PR
Restores #598 by directing update notices and cloudsmith update to version-specific Cloudsmith changelog entries instead of GitHub release pages.
Changes:
- Converts versions such as
2.0.0andv2.0.0into the slugcli-v2-0-0, preserving the GitHub fallback when no version is known. - Updates URL tests, adds multi-digit version coverage, and documents the change.
| File | Description |
|---|---|
cloudsmith_cli/core/tests/test_installation.py |
Updates expected URLs and adds multi-digit version coverage. |
cloudsmith_cli/core/installation.py |
Generates version-specific Cloudsmith changelog URLs. |
CHANGELOG.md |
Documents the new update-link destination. |
Review effort: Balanced
apoclyps
approved these changes
Nov 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR puts back #598. The update notice and
cloudsmith updatelink to the version's entry in the Cloudsmith changelog (https://cloudsmith.com/changelog/cli-v<major>-<minor>-<patch>). Before, they linked to the GitHub release page.Commit b4e7ca4 reverted #598 on master. Merge this PR when the change is ready to ship again.
Type of Change
Additional Notes
The diff is the same as #598. Only the CHANGELOG line offset is different.
🤖 Generated with Claude Code