Conversation
enclave/Dockerfile copies a prebuilt ./bin/tee-auction-enclave, so the documented docker build failed on a clean checkout. Add the go build command from docker.yml and pin the image platform to match GOARCH. Drop the openauction/enclave import from the usage example: enclave is package main and cannot be imported.
5 of 6 tasks
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation now accurately reflects the Dockerfile and workflow behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Updates README instructions to align with the current prebuilt enclave binary workflow.
Changes:
- Removes the invalid
package mainenclave import. - Documents arm64 binary and Docker image builds, including amd64 substitutions.
| File | Description |
|---|---|
| README.md | Corrects imports and enclave build instructions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
enclave/Dockerfilecopies a prebuilt./bin/tee-auction-enclave, so the README'sdocker buildfails on a clean checkout with"/bin/tee-auction-enclave": not found. The README now runs thego buildcommand from.github/workflows/docker.ymlfirst, with the same flags and the workflow's defaultGOARCH=arm64. Thedocker buildline gets--platform linux/arm64, so the image platform matches the binary, as the workflow'splatformsinput does. One line gives the amd64 variant that the workflow's manual dispatch offers. On an amd64 Linux host, the image'sRUNsteps need arm64 emulation, so the README gives thetonistiigi/binfmtcommand thatdocker/setup-qemu-actionruns in the workflow.github.com/cloudx-io/openauction/enclave. That directory ispackage main, and Go rejects the import:is a program, not an importable package..gitignorenow ignores/bin/, so the README build leavesgit statusclean. No tracked file lives under abin/directory.Notes for reviewers
The README's
docker buildline matched the original multi-stage Dockerfile. #7 moved compilation intodocker.ymlto make image builds faster and more cacheable, and the README kept the old step. This PR keeps the prebuilt-binary design and documents the step it needs.Pre-merge checklist
bash, build a static linux/arm64 ELF binary and alinux/arm64image. The amd64 variant builds a static x86-64 binary and alinux/amd64image.go buildline is byte-identical to the one indocker.yml, with${ARCHITECTURE}at itsarm64default.core,enclaveapi) compiles in a scratch module that replacesgithub.com/cloudx-io/openauctionwith this branch. Withenclaveadded back, the build fails as described above.lint,testandRatchet Lintpass, and Docker Build run 36878528554 built the head commit without publishing. Neither workflow runs the README commands.git status --porcelainprints nothing, andgit check-ignorematches the binary to/bin/.README.mdand.gitignoreonly.Not run: the image itself, which needs a Nitro Enclave host, and the emulation command, which needs an amd64 Linux host. The EIF build runs only on
main.Post-deploy/apply verification
mainafter the merge is green, includingupdate-pcrs