Skip to content

Apply title normalisation feedback #941

Closed

Description

@alistairjcbrown

Apply feedback to #937
Do not create a new branch, use the branch from the PR. You have permission to commit and push to the branch from the PR.

Activity

  1. alistairjcbrown commented on Nov 11, 2026

    @alistairjcbrown
    MemberAuthor
  2. alistairjcbrown commented on Nov 11, 2026

    @alistairjcbrown
    MemberAuthor

    All 11 review comments on #937 are applied, pushed to its branch as 6de2bd6. No new branch or PR.

    Done

    • Phrases added: "Drink-Along", " x Koshin-san Workshop", "Workshop & Screening", "Private Premiere", "From Shadows to Light:", "Paint-By-Numbers Workshop", "screening at Divine".
    • Corrections added: Thunderbirds 2026 double bill, The Three Dumas (2007), Two Gentlemen Sharing.
    • test-titles.json outputs updated. Exactly the 11 reviewed titles change; no other title moves. Lint and the normalise-title tests pass.

    Different from what you asked

    • "Soft Limit Cinema - " is a correction (/^Soft Limit Cinema - /i), not a phrase. The separator rule cuts the title at the dash before the phrase list runs, so a phrase entry would never match. "UK Premiere" was already in the list. Result: head over heels.
    • The Thunderbirds correction sits ahead of the year rule, which otherwise strips the "2026" it matches on. Result: thunderbirds double bill atlantic inferno, the same key as the existing "Thunderbirds 4K Double Bill - Atlantic Inferno / …" title.

    Decision needed

    Your review on #937 is still pending (unsubmitted), so I left the threads unresolved.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions