Repository navigation
Parse a Tito event's time only once it matches a venue - #936
Merged
Merged
Conversation
Tito lists every event an organiser runs, and one in Canterbury with a date and no time failed transform-prepare for every venue. The calendar text is now parsed after the venue match, so such an event still stops the run at a venue we carry and is passed over anywhere else. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GBhsxWaH5bizzTJXocRH48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
transform-preparefailed again after #935, this time with:https://ti.to/queereast/girlfriends_uok_2026 gives a date and no time, and the parser expects a start–end time range. The event is at the University of Kent in Canterbury, so it could never match a venue we carry, but the calendar text was parsed for every event before the venue check. A throw in any source's
findEventsfailstransform-prepare, so it blocked every venue.Change
The calendar text is now parsed in
convertTitoEvent, after the event has matched the cinema being checked.Testing
sources/ti.to/tests/index.test.js, using the markup from the live page: passed over for a cinema it isn't at, and throws for the cinema it is at.npm test -- sources/ti.topasses (8 tests, 3 snapshots unchanged).findEventsover all four events Queer East currently lists (two at Kent, two at East Anglia) against The Garden Cinema and BLOC: no error, no matches.transform-prepareagainst the run's retrieved data.Generated by Claude Code