Reverts Valkyrie Tantrum Activation - #13174
deadspacemkii wants to merge 1 commit into
Conversation
|
The ability design has nothing to do with selecting or unselecting, its meant to be so you can use it on the go without having to switch abilities. Because as a valkyrie youre meant to be in there slashing, using your knockdown etc while buffing, this just skips the step of changing abilities and missing out on a stomp or being distracted. It's a quick ability usage since you mainly want to be on your middle ability anyway. I think people will appreciate the current way more when their muscle memory gets used to it, i dont really care if this goes through or not thats just my standpoint |
|
Hi, please make the changelog entry more descriptive |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
Partially reverts #13046 which changed valkyrie's tantrum ability to use a different activation method. This PR reverts tantrum to how it used to be, but leaves the rest of the code for stuff like new strains or castes.
Explain why it's good for the game
The new ability activation, quite frankly, sucks. I've asked almost every valk I've seen if they like the new activation changes and not a single person said yes. It just feels absolutely terrible to use the ability now because if you have to jump through so many hoops just to use or turn the ability off. Clicking more than once with tantrum will often cause you to waste whatever other ability you have selected. Having to turn off the ability instead of switching it like every other ability in the game is also just bad design, there exists a toggle in the preferences menu for this exact reason.
Testing Photographs and Procedure
Works like how it used to
Changelog
🆑 deadspacemkii
qol: Reverts valkyrie's tantrum ability to use XENO_ACTION_CLICK instead of XENO_ACTION_QUEUE. It now remains selected even after it's used and can only be deselected if the appropriate preference is enabled.
/:cl: