Repository navigation
Conversation
Validate the container edits at the beginning of Apply so that invalid edits are rejected before the OCI Spec is touched, also when Apply is called directly without validating the edits first. Also closes some gaps in the validation: - reject nil entries in device nodes, net devices, hooks and mounts instead of panicking - reject negative device numbers in device nodes, as -1 is interpreted as a wildcard Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
marquiz
force-pushed
the
devel/container-edits-validate
branch
from
October 1, 2026 19:22
0b53029 to
0e81449
Compare
elezar
reviewed
Oct 12, 2026
elezar
left a comment
elezar
left a comment
Contributor
There was a problem hiding this comment.
My one question is whether we want to skip nils instead of treating them as invalid? Not sure how regularly this would come up though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate the container edits at the beginning of Apply so that invalid edits are rejected before the OCI Spec is touched, also when Apply is called directly without validating the edits first.
Also closes some gaps in the validation: