Repository navigation
Set VERSION to 0.1.0 for the first release - #15
Merged
Merged
Conversation
VERSION has been the placeholder "dev" since the first commit. The release workflow gates on the git tag matching it, so no tag could ever publish: the tag push succeeded, CI ran the safety audit and the unit suite, and the job then failed at the version check with nothing released. That gate is doing what it should -- refusing to publish an artifact whose recorded version disagrees with the tag it came from. The problem is only where the disagreement surfaces. Pushing a tag is the least reversible step in the release, and it was the step that told you the version was wrong. Add a unit test requiring VERSION to be a release number rather than a placeholder, so main is always taggable and the mismatch is caught locally instead of after a tag exists. Then set it to 0.1.0. Nothing else changes. The workflow still publishes the tagged file unmodified, so the released bytes stay identical to the tag. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VERSIONhas been the placeholder"dev"since the first commit. The releaseworkflow gates on the git tag matching it, so no tag could ever publish. Pushing
v0.1.0demonstrated this: the tag push succeeded, CI ran the safety audit andthe full unit suite, and the job then failed at the version check with nothing
released.
The gate is doing what it should — refusing to publish an artifact whose
recorded version disagrees with the tag it came from. The problem is only
where the disagreement surfaces. Pushing a tag is the least reversible step in
the release, and it was the step that told you the version was wrong.
What this changes
A unit test requiring
VERSIONto be a release number rather than aplaceholder, so
mainis always taggable and a mismatch is caught locallyinstead of after a tag exists. Then
VERSION = "0.1.0".Nothing else. The workflow still publishes the tagged file unmodified, so the
released bytes stay byte-identical to the tag and
git show v0.1.0:dbprofiler.py | diff - dbprofiler.pystays empty.Verification
python3 -m unittest— 383 tests, OK (382 before; this adds one)python3 dbprofiler.py --check-safety— OK, 14 SQL constantspython3 dbprofiler.py --version—0.1.0ruff check— all checks passedThe existing version tests were already value-agnostic, so none needed changing.
After merge
Re-tag the merged commit to exercise
Checksum,Attest build provenance, andPublish— the three steps that touch GitHub's release and OIDC APIs and arestill unproven.