style(rubocop): resolve Rails/UniqueValidationWithoutIndex with DB indexes - #2771
Merged
Conversation
KimberleyCook
approved these changes
Aug 2, 2026
mroderick
force-pushed
the
fix/unique-validation-index
branch
from
August 4, 2026 09:21
e70ae4c to
78f0b2e
Compare
Collaborator
Author
|
This PR made me realise that we didn't have any protections against making silly mistakes with adding indexes during migrations, which caused me to create #2774, which added the strong migrations gem. Now that it has been merged, I've updated this PR to create indexes using It's ready for review! |
mroderick
marked this pull request as ready for review
August 4, 2026 09:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves
Rails/UniqueValidationWithoutIndexby adding unique database indexes that back existing uniqueness validations.Changes
AuthServiceuidscoped toprovider[uid, provider]uniqueChapternameuniquenameuniqueChapteremailuniqueemailuniqueFeedbackRequestmember_idscoped toworkshop[member_id, workshop_id]uniqueFeedbackRequesttokenuniquetokenuniqueInvitationmember_idscoped to[event_id, role][member_id, event_id, role]uniqueMeetingInvitationmember_idscoped tomeeting_id[member_id, meeting_id]uniqueWorkshopInvitationmember_idscoped to[workshop_id, role][member_id, workshop_id, role]uniqueWorkshopSponsorsponsor_idscoped toworkshop_id[sponsor_id, workshop_id]uniqueAlso fixed
AuthService's validation syntax:constraint: :provider(non-standard, ignored by Rails) →scope: :provider.Verification
Migrated cleanly against development and test databases with no duplicate-key errors. All model and controller specs pass.