Skip to content

V0.12.0/dotnet new major bump - #48

Open
gimlichael wants to merge 13 commits into
mainfrom
v0.12.0/dotnet-new-major-bump
Open

gimlichael wants to merge 13 commits into
mainfrom
v0.12.0/dotnet-new-major-bump

Conversation

@gimlichael

Copy link
Copy Markdown
Member

This pull request introduces the native Microsoft Testing Platform test stack alongside vendor-neutral agent guidance for both .NET scaffolds. Generated solutions resolve compatible Codebelt 12.x and xUnit 4.x lines with Codebelt Coverlet coverage, while root AGENTS.md becomes the single instruction contract. Validators and documentation record both contracts for reviewers.

Native test stack:

  • Generated solutions use compatible major test lines with central versioning and coverage diagnostics
  • New projects select the native runner and verify discovery plus test and coverage output for each executable target
  • Host behavior is exercised through managed fixtures without legacy blocking types or extra report packages

Vendor-neutral agent guidance:

  • Generated repositories carry a single vendor-neutral instruction contract with complete governance examples preserved
  • Vendor-specific instruction files are removed from manifests, inventories, and bot-workspace pointers
  • Coding, testing, coverage, benchmarking, documentation, and workspace rules stay intact without summarization

Scaffold guidance:

  • Scaffold instructions define compatible version lines, runner selection, and required shared inventory for both solution types
  • Reference guides describe the required output tree and testing approach without optional omissions
  • Evaluation expectations require the single instruction source and the coupled test contract

Validation and regression coverage:

  • Validators enforce runner selection, package references, instruction inventory, and complete governance examples
  • Regression coverage builds representative scaffolds and checks inventory, guidance, discovery, and coverage output

Documentation:

  • Root documentation surfaces both the native test stack and the single instruction contract for consumers

Both scaffolds now define the coupled Codebelt 12.x and xunit.v3 4.x contract with native Microsoft.Testing.Platform selection, Codebelt Coverlet coverage, and executable TFM validation so generated solutions restore and report consistently.
Scaffold output now references Codebelt Coverlet MTP and HangDump instead of legacy Coverlet packages, selects the native Microsoft.Testing.Platform runner through root global.json, and resolves test packages on the Codebelt 12.x and xunit.v3 4.x lines so generated solutions build with current test dependencies.
Generated contributing guides, agent instructions, and readmes now run tests with --report-xunit-trx plus Codebelt Coverlet and verify TRX and OpenCover output, matching the committed skill contracts without a separate TRX provider.
Validators enforce the MTP runner opt-in, package references, and xUnit reporting flags while the new regression script builds representative scaffolds and verifies discovery, TRX, coverage, and HangDump options with no separate TRX provider.
Root documentation surfaces the native MTP test stack with xUnit built-in TRX reporting and the supported SDK requirement so consumers understand the generated test setup before scaffolding.
Replace the vendor-specific instruction file with root AGENTS.md as the single generated agent-instruction source while preserving the complete testing, coverage, benchmarking, XML documentation, and bot-workspace contract without summarization.
Expand the shared AGENTS.md governance contract, remove the Copilot-specific instruction file from the manifest and disk, and retarget bot-workspace guidance to root AGENTS.md.
Enforce the sole AGENTS.md inventory, forbid vendor-specific instruction semantics, and assert the nine complete governance examples plus coverage and benchmark applicability.
Describe the vendor-neutral root AGENTS.md contract so generated repositories advertise a single agent-instruction source.
@gimlichael gimlichael self-assigned this Oct 4, 2026
@greptile-apps

greptile-apps Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Medium risk] Updates dotnet testing framework versions and tooling.

The PR should satisfy the repository’s public-class documentation requirement before merging; no new blocking functional defect was established.

Fix All in CodexFindings

  1. P2 Public class lacks XML documentation ▶
Fix with agent prompt
### Issue 1
skills/dotnet-new-app-slnx/assets/app/console/Program.minimal.cs:6
The changed public `Program` class has no XML documentation comment. Repository instructions require XML comments on all public classes, so this requirement must be satisfied before merging.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR moves both .NET scaffolds to xUnit 4, Codebelt 12, native MTP testing and a single generated AGENTS.md instruction contract.

  • Adds scaffold build, discovery and coverage regression checks, including framework-selection and incompatibility cases.
  • Updates package-resolution guidance, validators and consumer documentation.

Reviews (2) · Last reviewed commit: "📚 describe executable TFMs and provisio..."

Comment thread scripts/validate-skill-templates.ps1 Outdated
Comment thread scripts/tests/test-scaffold-mtp.ps1
Comment thread skills/dotnet-new-app-slnx/scripts/resolve-package-versions.ps1
Comment thread skills/dotnet-new-app-slnx/assets/shared/AGENTS.md Outdated
Version-index selections stay provisional until metadata inspection plus combined restore and build confirm compatibility, while executable TFMs keep source-only frameworks out of test and benchmark targets.
Test and benchmark templates render the executable TFM subset while the resolver marks version-index selections provisional, and shared agent guidance drops the duplicated functional-test namespace rule.
Revision-aware validation skips working-tree scaffold execution while the MTP harness covers provisional status, net8 incompatibility, executable TFM rendering, and benchmark projects.
Keep the solution overview in sync with the scaffold behavior for source-only framework exclusion and provisional package compatibility.
namespace {ROOT_NAMESPACE}.{AppType};

public class Program : MinimalConsoleProgram
public class Program : MinimalConsoleProgram<Program>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Public class lacks XML documentation The changed public Program class has no XML documentation comment. Repository instructions require XML comments on all public classes, so this requirement must be satisfied before merging.

Context Used: AGENTS.md (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: skills/dotnet-new-app-slnx/assets/app/console/Program.minimal.cs
Line: 6

Comment:
**Public class lacks XML documentation** The changed public `Program` class has no XML documentation comment. Repository instructions require XML comments on all public classes, so this requirement must be satisfied before merging.

**Context Used:** AGENTS.md ([source](https://github.com/codebeltnet/agentic/blob/main/AGENTS.md))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants