Skip to content

V5.0.13/prepare refactoring - #62

Merged
gimlichael merged 8 commits into
mainfrom
v5.0.13/prepare-refactoring
Oct 5, 2026
Merged

gimlichael merged 8 commits into
mainfrom
v5.0.13/prepare-refactoring

Conversation

@gimlichael

Copy link
Copy Markdown
Member

This pull request refreshes the docs publishing pipeline and clarifies local test guidance. It also expands regression coverage for configured options, automatic discovery, and JSON message handling.

Docs publishing:

  • Reliable DocFX container restore with hardened error handling and a lean build context
  • Nginx based docs serving with dedicated config, corrected links, and mobile navigation
  • Separate member pages and refreshed site rendering for published API docs

Contributor guidance:

  • Correct local test invocation syntax for per-project runs
  • Clarified integration dependent exclusions from the normal test matrix

Test coverage:

  • Consistent configured options behavior across data source and messaging extensions
  • Automatic dispatcher, handler, and assembly discovery without duplicates
  • JSON converter guards and concrete CloudEvent resolution across both marshallers

Harden the DocFX container build with reliable restore and error handling, switch serving to dhi.io nginx with dedicated config and dockerignore, and refresh site rendering with separate member pages, ms-style template, mobile TOC action bar, corrected GitHub link, and sitemap for docs.savvyio.net.
Fix the dotnet test invocation to use --project syntax and clarify that excluded test projects are integration-dependent so contributors run the correct local test slice.
Characterize the current separate eager options instance before the Cuemon migration, ensuring direct, Microsoft Options, and callback forms stay consistent across data source and messaging extensions.
Lock in CurrentDomain brute-force scanning for dispatchers and handlers, including duplicate-free handler results.
Lock in ordinal System and Microsoft prefix filtering, transitive dependency traversal, and CurrentDomain caching semantics.
Guard null writer behavior and ensure concrete CloudEvent types are discovered while abstract candidates are ignored across both JSON marshallers.
@gimlichael gimlichael self-assigned this Oct 5, 2026
@greptile-apps

greptile-apps Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Test coverage expansion and documentation build pipeline updates.

The PR appears safe to merge based on the issues established in this review.

Summary

This PR refreshes the DocFX publishing pipeline and contributor test guidance, and adds regression tests for options registration, discovery, and JSON message handling.

  • The changes since the previous review replace the test coverage package and add a hang-dump extension.
  • The previous DocFX template thread is resolved; no new actionable finding was established.

Reviews (3) · Last reviewed commit: "🔧 swap test coverage to coverlet with h..."

Comment thread .docfx/docfx.json
Finalize the v5.0.13 patch entry from branch evidence covering DocFX pipeline hardening, contributor guidance, and expanded test coverage.
Replace Microsoft.Testing.Extensions.CodeCoverage with Codebelt.Coverlet.MTP for test coverage and add Microsoft.Testing.Extensions.HangDump to diagnose hung test runs.
@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.70%. Comparing base (a0af51f) to head (6cea8c8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   98.62%   98.70%   +0.08%     
==========================================
  Files         177      177              
  Lines        3783     3643     -140     
  Branches      365      327      -38     
==========================================
- Hits         3731     3596     -135     
+ Misses         50       46       -4     
+ Partials        2        1       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gimlichael
gimlichael merged commit 3dfb553 into main Oct 5, 2026
249 checks passed
@gimlichael
gimlichael deleted the v5.0.13/prepare-refactoring branch October 5, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants