Repository navigation
GET /audit-logs is unreachable: auditLogsRouter is not mounted in app.ts #648
Description
auditLogsRouter is defined in apps/backend/src/routes/auditLogs.ts but apps/backend/src/app.ts never imports or mounts it, so GET /audit-logs returns 404 on a running server. src/__tests__/auditLog.test.ts passes because it mounts the router on its own Express app.
The route also has no rate limiter and parses limit, cursor and action by hand instead of through a schema.
Fix: add app.use('/audit-logs', auditLogsRouter) in app.ts after the global_ip rate limit, add a rate limit bucket, and add a test that requests the path through app.
Found while writing #617.
Activity
glendell03 commentedon Oct 20, 2026
I'd like to take this one, please assign it to me.
auditLogsRouterinapps/backend/src/routes/auditLogs.tsis never imported inapps/backend/src/app.ts, soGET /audit-logs404s.auditLog.test.tshides this by mounting the router on its own Express app.My plan:
app.use('/audit-logs', auditLogsRouter)after theglobal_iprate limit.limit,cursorandactionwith a schema, rejecting bad values with a 400./audit-logsthroughappitself, so a missing mount fails.One question: should the new bucket reuse an existing limit config, or get its own numbers? I'd rather agree that before coding than rework it afterwards.
Ikechukwu-Patrick commentedon Oct 20, 2026
@Ikechukwu-Patrick has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ikechukwu-Patrick to this issue.
iorchirmyom-afk commentedon Oct 20, 2026
@iorchirmyom-afk has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @iorchirmyom-afk to this issue.
cythecode commentedon Oct 20, 2026
@cythecode has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @cythecode to this issue.
kosisochukwu1234 commentedon Oct 20, 2026
@kosisochukwu1234 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @kosisochukwu1234 to this issue.
drips-wave commentedon Oct 20, 2026
Congratulations, @kosisochukwu1234! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @kosisochukwu1234: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
docs: X3DH/Double Ratchet implementation notes, device-linking flow, …
github-actions commentedon Oct 28, 2026
Closed by #694, merged into
dev.