feat: anti-slop + contract-change sweep, and repo-wide test-value audit - #88
Merged
Conversation
Two stacked campaigns over the non-critical surfaces. Anti-slop lint campaign (waves I/J/K + shape): 849 -> 366 findings; ledger docs/anti-slop-curiosities.md; system core freeze intact. Contract-change alignment sweep: 271 authority claims audited across six lanes (vocabulary, boundary, flow, state, policy, proof), 16 remediation clusters, unresolved = 0. Ledger docs/contract-change-ledger.md carries per-iteration instruments, collision re-scans, and every flagged owner decision. Highlights: shared JSON + lane-receipt vocabulary in _assertions; verification harnesses driven through the production engine adapter; producer-owned ProjectManifest (dead snake/camel tolerance removed); session publication exclusivity + ExtractionSession.close(); one owner each for the commit/lock wire contracts (EPERM=alive); engine-transform extension-gate unification (.mjs divergence fixed); fail-loud parse policy for internal wires; C-016 loader seam (no-module-mocking now 0); hygiene live-gate gitignore-vacuity fix; build graph de-duplication (toolchain gate + double-writer race); withAnimus type portability (TS2742) repairing the next-app/next16-app lanes. Ratchet: .abstraction-owners.json (16 canonical names, exceptions calibrated non-vacuous) + .collision-report.json (hooks remain OFF; enabling is an owner decision). Verification: compile/types/canary/unit-ts(1808)/unit-rust/clippy/ workers/hygiene:rust/parity(65/65, baselines untouched)/integration plus 7 consumer owner lanes green. Known reds: verify:lint (standing 366 anti-slop debt) and verify:packed (environmental next 15.5.23 vs @types/react 18 drift; instrument unchanged — see ledger closeout). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Two follow-up chips from the contract-change campaign: - parseFilesJson now decodes through parseInternalWire, naming the wire, reader, and cause on malformed JSON (recorded contract reversal: the bare-SyntaxError pin asserted the asymmetry itself) - storedManifest: any retired in vite-plugin's PluginContext (ProjectManifest | null); the three dependent local manifest models plus a fourth private re-model deleted (net -93 lines); dead partial-manifest guards removed with impossibility arguments; test fakes completed via a local makeManifest/makeComponent fixture Proven: compile 0; vite-plugin 205/205; extract/next/unplugin suites 466 green; integration 165; vite-plugin owner lane (16 tasks) green; tests type-checked clean including the cross-package prerequisite import (0 errors); anti-slop 366 unchanged. Follow-up chip filed: snapshotFilePlans(manifest: any) + run-analysis's sheets guard, kept alive by ~18 next-plugin partial-manifest mocks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ert witnesses Repo-wide audit of all 175 active test files (multi-agent fleet + adversarial defense pass + two independent consultants). Net -977 lines of test code with coverage preserved or strengthened; verify:full green (43 tasks). Latent bugs fixed test-first: - reconcile-after-knip stripped LIVE .d.ts re-exports as `target-deleted` (data loss): .d.ts/index.d.ts added to resolveRelativeModule candidates, design-mandated CJS export= fixture restored and mutation-gated. - e2e cross-fixture guards were inverted (missed real imports, tripped on comments): replaced by an oxc-based `fixture-sibling` vector in topology.ts covering all 8 fixtures (e2e-workspace-convention witness), calibrated fail-first; both regex guards deleted as subsumed. - manifest-shape provenance-reciprocity loops iterated an empty reverse_provenance: new extended.tsx extension fixture makes them real; parity corpus refreshed via intent test-value-audit-extension-fixture-20260818 (65/66 pre-existing units byte-identical). Consolidations: Vite post-process mirror deleted after porting its 4 uniquely witnessed css-post-processing scenarios to the production-helper suite; unused assertPropertyRegistrationSplit stack deleted, @Property split tests rehomed to canary; analyze-project-args and manifest-diagnostics clone families deduped; key-enumeration runs collapsed to exact-shape assertions; tautologies and vacuous tests removed. Every port fail-first proven via production mutation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQuCHBc6HCuzoa77JyBwA4
…ct-change # Conflicts: # packages/_assertions/__tests__/receipt.test.ts # packages/_integration/__tests__/extraction.test.ts # packages/_integration/__tests__/manifest-shape.test.ts # packages/_integration/__tests__/serialization.test.ts # packages/extract/tests/canary.test.ts # packages/extract/tests/error-diagnostics.test.ts # packages/next-plugin/tests/session-artifacts.test.ts # packages/oracle/__tests__/engine-prove-refine.test.ts # packages/oracle/__tests__/engine-simulate-diff.test.ts # packages/oracle/__tests__/fixture-world.ts # packages/oracle/__tests__/places-session.test.ts # packages/system/__tests__/createClassResolver.test.ts # packages/system/__tests__/serialized-config.test.ts # packages/system/__tests__/theme.test.ts # packages/vite-plugin/tests/transform-source.test.ts # scripts/hygiene/delete-unused.test.ts # scripts/verify/topology.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bodies of work on this branch, both fully verified:
Anti-slop wave + contract-change alignment sweep (302f035..bea8a52)
verify:lintto exit 0: 849 → 0 active oxlint findings via the local anti-slop plugin (tools/oxlint/anti-slop), with 3 latent bugs fixed en route and 3 parity-pinned lint exclusions documented.storedManifestany removed, the filesJson wire named); ratchet files landed.Test-value audit (e2bb5c6)
Repo-wide audit of all 175 active test files — a 13-auditor fleet with an adversarial defense pass (59% of findings died in defense), two independent consultants, and edit-time re-verification of every consolidation. Net −963 test lines with coverage preserved or strengthened.
Three inert witnesses repaired (each concealed or enabled a real defect):
.d.tsre-exports astarget-deleted(data loss). Resolver now probes.d.ts/index.d.ts; the design-mandated CJSexport =fixture is restored and mutation-gated.fixture-siblingvector intopology.tscovering all 8 fixtures — thee2e-workspace-conventionwitness — calibrated fail-first (3 planted forms trip, comment fixtures stay green); both regex guards deleted as subsumed.reverse_provenance(no fixture used.extend()). Newextended.tsxfixture makes them real; parity corpus refreshed via checked intenttest-value-audit-extension-fixture-20260818with 65/66 pre-existing units byte-identical.Consolidations: the Vite post-process mirror (tested a local copy, never production) deleted after porting its 4 uniquely-witnessed spec scenarios to the production-helper suite; unused
assertPropertyRegistrationSplitstack deleted with@propertysplit tests rehomed to canary;analyze-project-args/manifest-diagnosticsclone families deduped; key-enumeration runs collapsed to exact-shape assertions; tautologies and vacuous tests removed. Every port was fail-first proven by mutating the production target.Verification
vp run verify:fullexit 0 at HEAD (43 tasks: root fast tier, every consumer owner build+assert, parity, integration, Rust hygiene, packed proof). Parity oracle extended, not rewritten. End-of-work hygiene scan converged; its 29 flagged lines inpackages/system/srcare runtime-src candidates deferred as follow-up (knip blind-spot territory).🤖 Generated with Claude Code
https://claude.ai/code/session_01DQuCHBc6HCuzoa77JyBwA4