Skip to content

Fix mobile menu so top-level parent links are navigable. #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bernardhanna wants to merge 1 commit into from
+33 −13
Closed

Fix mobile menu so top-level parent links are navigable. #3617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions public/js/ext/functions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,24 @@
var $ = jQuery.noConflict();

function codeweekMobileMenuLinkClick(e) {
var $link = $(this);
var $submenu = $link.parent().children('ul');

if (!$submenu.length) {
return;
}

var href = $link.attr('href') || '';
var isVoidHref = !href || href === '#' || href.indexOf('javascript:') === 0;
var clickedArrow = $(e.target).closest('.arrow-icon').length > 0;

if (clickedArrow || isVoidHref) {
e.preventDefault();
$submenu.toggleClass('show');
return false;
}
}

$.fn.inlineStyle = function (prop) {
return this.prop("style")[$.camelCase(prop)];
};
Expand Down Expand Up @@ -879,9 +898,7 @@ var SEMICOLON = SEMICOLON || {};
if ( $().superfish ) {
var menuSelector = '#primary-menu > ul';
$(menuSelector).superfish('destroy');
$('#primary-menu ul li a').click(function() {
$(this.parentNode).children('ul').toggleClass('show')
});
$('#primary-menu ul li a').click(codeweekMobileMenuLinkClick);
}
},

Expand Down Expand Up @@ -2427,9 +2444,7 @@ var SEMICOLON = SEMICOLON || {};
});
if( SEMICOLON.isMobile.any() || !$body.hasClass('device-lg')){
$body.addClass('device-touch');
$('#primary-menu ul li a').click(function() {
$(this.parentNode).children('ul').toggleClass('show')
})
$('#primary-menu ul li a').click(codeweekMobileMenuLinkClick);
}

/*DROPDOWN MENUS*/
Expand Down
19 changes: 12 additions & 7 deletions resources/views/layout/menu.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,19 +90,22 @@ class="cookweek-link hover-underline !text-[#1C4DA1] !text-[16px]"
{{-- resources --}}
<li class="main-menu-item">
<a
class="cookweek-link hover-underline !text-[#1C4DA1] !text-[16px] cursor-pointer"
onclick="document.body.clientWidth > 1280 && (window.location.href='{{ route('educational-resources') }}')"
class="cookweek-link hover-underline !text-[#1C4DA1] !text-[16px]"
href="{{ route('educational-resources') }}"
>
@lang('menu.resources')
<img class="arrow-icon" src="/images/chevron-down-icon.svg" alt="">
</a>
<ul class="sub-menu">
<li class="menu-title max-xl:!hidden">
<a class="flex gap-2 items-center" href="{{route('educational-resources')}}">
<a class="flex gap-2 items-center" href="{{route('educational-resources')}}">
@lang('menu.resources')
<img src="/images/arrow-right-icon.svg" class="menu-title-icon" />
</a>
</li>
<li class="xl:hidden">
<a class="cookweek-link hover-underline" href="{{ route('educational-resources') }}">@lang('menu.resources')</a>
</li>
<li class="flex flex-col gap-16 xl:flex-row">
@php
$resourcesDropdownSections = $resourcesDropdownSections ?? collect();
Expand Down Expand Up @@ -231,13 +234,14 @@ class="absolute top-0 left-0 w-full h-full"
{{-- community --}}
<li class="main-menu-item">
<a
class="cookweek-link hover-underline !text-[#1C4DA1] !text-[16px] cursor-pointer"
onclick="document.body.clientWidth > 1280 && (window.location.href='{{ route('community') }}')"
class="cookweek-link hover-underline !text-[#1C4DA1] !text-[16px]"
href="{{ route('community') }}"
>
@lang('community.titles.0')
<img class="arrow-icon" src="/images/chevron-down-icon.svg" alt="">
</a>
<ul class="sub-menu">
<li class="xl:hidden"><a class="cookweek-link hover-underline" href="{{ route('community') }}">@lang('community.titles.0')</a></li>
<li><a class="cookweek-link hover-underline" href="{{ route('grassroots-grants') }}">@lang('menu.grassroots_grants')</a></li>
</ul>
</li>
Expand Down Expand Up @@ -290,13 +294,14 @@ class="cookweek-link hover-underline !text-[#1C4DA1] !text-[16px]"
{{-- blog --}}
<li class="main-menu-item">
<a
class="cookweek-link hover-underline !text-[#1C4DA1] !text-[16px] cursor-pointer"
onclick="document.body.clientWidth > 1280 && (window.location.href='https://codeweek.eu/blog/')"
class="cookweek-link hover-underline !text-[#1C4DA1] !text-[16px]"
href="https://codeweek.eu/blog/"
>
@lang('menu.blog')
<img class="arrow-icon" src="/images/chevron-down-icon.svg" alt="">
</a>
<ul class="sub-menu">
<li class="xl:hidden"><a class="cookweek-link hover-underline" href="https://codeweek.eu/blog/">@lang('menu.blog')</a></li>
<li><a class="cookweek-link hover-underline" href="https://forms.office.com/Pages/ResponsePage.aspx?id=18F13DIal06vkB3AGRHqbCnyIKB_vXdLsUgagfjd7DRUN1dZTVYxSkJNQ1VWSlVZNlpBOFAyN0g4UC4u&amp;embed=true" target="_blank" rel="noopener">@lang('menu.share_your_stories')</a></li>
</ul>
</li>
Expand Down
Loading