Repository navigation
Conversation
Member
|
@Balrocj coul dyou please upload vsix? |
Contributor
Author
|
@buzzia2001 I built the VSIX from this branch and attached it here for testing. It includes the fix for SQL statements that complete successfully without returning a result set. GitHub does not allow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Copilot SQL runner tool when executing successful SQL statements that do not return a result set, such as
CREATE TABLE,DROP TABLE, orCREATE ALIAS.Previously,
JobManager.runSQL()could returnundefined. The tool passedJSON.stringify(undefined)intoLanguageModelTextPart, which also evaluates toundefinedand caused VS Code to throw an error when reading.length.The tool now always returns a consistent JSON payload:
{"success":true,"hasResultSet":false,"rows":[]}{"success":true,"hasResultSet":true,"rows":[...]}Tests
CREATE TABLEandDROP TABLEstatements through Copilot Chat.npm testpasses: 186 tests.npm run typingspasses.Fixes #562