Repository navigation
fix(providers): preserve tool input schemas for Anthropic and Google - #76
ibetitsmike wants to merge 2 commits into
Conversation
Anthropic (and Bedrock, which delegates to it) rebuilt input_schema from properties and required only, and dropped required when it was []any. Forward every other schema keyword through ExtraFields and accept both required shapes. Google converted only root properties into genai.Schema and turned any property without a type, including every $ref, into a string. Inline local references (any JSON Pointer, percent-decoded), convert enum, anyOf, nested required, and nullable alternatives, and drop recursive or unresolvable references together with their required entries instead of degrading them to strings.
|
@codex review
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b19528eeea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The Gemini API and Vertex AI accept JSON Schema directly through FunctionDeclaration.parametersJsonSchema. Send each tool schema there unchanged instead of converting it into the OpenAPI-style parameters field, which cannot express references, numeric enums, or untyped object roots and lost or corrupted tool arguments when converted. Remove the hand-written schema converter and update the recorded Google requests to the new declaration shape.
|
@codex review
|
|
@codex review
|
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Anthropic, Bedrock and native Google rebuilt every tool input schema from
propertiesandrequiredonly. Schemas from MCP servers that use$defsand$refreached the model with references that point at nothing. Google also turned every property without atype, including each$ref, into a string argument.Changes
toToolsforwards every top-level schema keyword excepttype,propertiesandrequiredthroughToolInputSchemaParam.ExtraFields. Examples are$defs,additionalPropertiesand the rootdescription.requiredis now also accepted as[]any, which is what JSON decoding produces.toGoogleToolssends each tool schema unchanged asFunctionDeclaration.parametersJsonSchemainstead of converting it into the OpenAPI-styleparametersfield. The old converter is removed. A tool with a nil schema sends neither field, so it declares no parameters.parametersJsonSchemaon both the Gemini API and Vertex AI, including$ref,$defs,anyOfandadditionalProperties. fantasy already uses the matchingresponseJsonSchemafield for object generation.genai.Schemacannot express references, numeric enums or untyped object roots. A converter must either drop those or inline references, and inlining expands exponentially on schemas that reference one definition more than once.providertestscassettes with tool declarations now recordparametersJsonSchemain place ofparameters. The only other change is the requestcontent_length. The schemas are the same objects with lowercase JSON Schema types.This replaces #53, which targeted
main.Validation
go test ./...passes, including all 82 Googleprovidertestscases that replay the recorded requests.golangci-lint run --allow-parallel-runners ./...reports no issues in the changed files. The 3 existingpreallocfindings are inagent.goandproviders/kronk.TestToolInputSchemaReachesRequestchecks the request body for both the Gemini API and Vertex backends. Its schema has an untyped root, a$refwith sibling keywords, a recursive definition, a numeric enum and a null branch behind a$ref. It fails with the basegoogle.go($refbecomesSTRING) and with this PR's first commit (the untyped root becomes{"type":"STRING"}).TestToTools_PreservesFunctionInputSchemafails with the baseanthropic.go.claude-haiku-4-5) through the Coder AI Gateway with aninput_schemathat carries$defs, a$refproperty,additionalProperties: falseand a rootdescription. It returned 200 and the tool call{"filter":{"term":"coder"}}.coder/coder consumes this in the MCP tool schema stack (coder/coder#28376).