Skip to content

flake: TestPromoteChatQueuedMessage #1615

Description

@flake-investigator

CI Failure Details

CI Run Link: https://github.com/coder/coder/actions/runs/28843531069
Failed Job: https://github.com/coder/coder/actions/runs/28843531069/job/85542337730 (test-go-pg (macos-latest))

Commit Info:

  • SHA: 8b60d1d8777ad65d51341f32672d32b9c9ce7f5a
  • Author: Ethan
  • Date: 2026-07-07T01:44:46Z
  • Commit: coder/coder@8b60d1d

Failure Output

=== FAIL: coderd TestPromoteChatQueuedMessage/WhileRunning (2.48s)
exp_chats_test.go:9738:
    Error:       "[]" should have 1 item(s), but has 0
    Test:        TestPromoteChatQueuedMessage/WhileRunning

Error Analysis

TestPromoteChatQueuedMessage/WhileRunning promotes a queued message while the chat is running and then expects GetChatQueuedMessages to return exactly one queued item (the promoted message) immediately after. In this run, the queued list was empty, indicating the queued message was drained before the assertion. This looks timing-sensitive: the background worker can auto-promote/dequeue the message before the test checks the intermediate queue state.

Root Cause Assessment

Classification: Flaky test (timing-sensitive async queue state)

Data race / crash checks

Scanned the failing job logs around the failure for WARNING: DATA RACE, panic:, and OOM indicators; none found.

Assignment Analysis

Intended blame:

  • git blame -L 9715,9745 coderd/exp_chats_test.go

Tooling limitation: line-level blame isn’t available here, so I used recent file history as a proxy.

Recent file history:

  • git log --oneline -10 --follow coderd/exp_chats_test.go
    • Most recent substantive change: 1eb5d579 ("fix: unblock manual chat title generation for unowned chats") by Michael Suchacz

Assigning to @ibetitsmike as the most recent meaningful modifier of the test file. Please reassign if another owner is more appropriate.

Related Issues

No direct duplicates found after searching for:

  • "TestPromoteChatQueuedMessage"
  • "TestPromoteChatQueuedMessage/WhileRunning"
  • "exp_chats_test.go"
  • "should have 1 item(s), but has 0"
  • "promote" + "queue" + "chat" in coder/internal

Related but different tests: #1529 (chatd promote queued message order), #1523 (promote queued while requires action) — different package/tests.

Reproduction (best effort)

go test ./coderd -run TestPromoteChatQueuedMessage -count=1

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions