Skip to content

chore: withdrawn - #139

Closed
dylanhuff-at-coder wants to merge 1 commit into
mainfrom
fix/derp-bound-dup-sendhistory
Closed

chore: withdrawn#139
dylanhuff-at-coder wants to merge 1 commit into
mainfrom
fix/derp-bound-dup-sendhistory

Conversation

@dylanhuff-at-coder

@dylanhuff-at-coder dylanhuff-at-coder commented Oct 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Withdrawn.

@dylanhuff-at-coder
fix(derp): bound dup client sendHistory growth
c6ba1a6 
Two connections that share a node key and take turns sending frames
made noteClientActivity append to dupClientSet.sendHistory on every
frame. The slice was only trimmed when a member disconnected, so it
grew without limit under the server's global mutex. DERP clients do
not need to authenticate, so any client could trigger this against an
embedded DERP server.

Move an existing entry to the end instead of appending a duplicate, so
sendHistory holds each member at most once.

Ported from upstream tailscale/tailscale@ec5d51098ab7 (tailscale#21477).
@dylanhuff-at-coder
dylanhuff-at-coder requested a review from a team as a code owner October 24, 2026 23:45
@dylanhuff-at-coder dylanhuff-at-coder mentioned this pull request Oct 24, 2026
Closed
@dylanhuff-at-coder dylanhuff-at-coder changed the title fix(derp): bound dup client sendHistory growth chore: withdrawn Oct 25, 2026
@dylanhuff-at-coder
dylanhuff-at-coder deleted the fix/derp-bound-dup-sendhistory branch October 25, 2026 00:54
@coder coder locked and limited conversation to collaborators Oct 25, 2026
@coder coder unlocked this conversation Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spikecurtis spikecurtis spikecurtis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dylanhuff-at-coder @spikecurtis