Conversation
Django 6.1 removed django.utils.cache.cc_delim_re (CVE-2026-48587 hardening, django/django@526b1b4), so importing wagtailcache.cache raises ImportError. Split the Vary header with django.utils.http.split_header_value, falling back to an equivalent local helper on Django < 6.1. Unlike the old regex, it strips whitespace around the first and last tokens too, so a padded 'Cookie' is still removed. Allow wagtail<9.0 and add the Wagtail 8 classifier and CI matrix entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Django 6.1 removed
django.utils.cache.cc_delim_reas part of the CVE-2026-48587 hardening (django/django@526b1b4), sowagtailcache.cachefails to import on 6.1:Changes:
Varyheader withdjango.utils.http.split_header_value, with an equivalent fallback for Django < 6.1. It also strips whitespace around the first and last tokens, which the old regex did not, so a paddedCookieis now removed.wagtail<9.0; add the Wagtail 8 classifier and apy3.13_wag8CI matrix entry.test_vary_header_parse_whitespace.Tested locally: 42 passed on Django 6.1.1 / Wagtail 8.0 (Python 3.14) and on Django 6.0.8 / Wagtail 7.4.3 (Python 3.13).