Repository navigation
fix: keep REST API responses out of page caches - #600
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Page caches were storing and replaying responses from the plugin's REST API. With LiteSpeed Cache active, the snippet list re-read after an activation toggle returned stale data until the cache was purged.
Changes
REST_Cache_Bypass, registered with the REST controllers. Onrest_post_dispatch, for any route undercode-snippets/v*, it:Cache-Control,Pragma,Expires,X-LiteSpeed-Cache-Control,X-Accel-Expires,Surrogate-Control,CDN-Cache-Control,Cloudflare-CDN-Cache-ControlandX-Cache-Enabledon the response;DONOTCACHEPAGEand fireslitespeed_control_set_nocache.code_snippets/rest_api/bypass_cachefilter to switch the behaviour off.Routes outside the plugin's namespace are not modified.
Verification
REST_Cache_Bypass_Test; full suite passes on this branch (364 tests, 25 skipped).