feat(acme): add separate EAB credentials for custom-domain certificates - #735
Open
OliverTrautvetter wants to merge 6 commits into
Open
feat(acme): add separate EAB credentials for custom-domain certificates#735OliverTrautvetter wants to merge 6 commits into
OliverTrautvetter wants to merge 6 commits into
Conversation
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
OliverTrautvetter
marked this pull request as ready for review
August 25, 2026 13:13
joka134
requested changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for configuring separate ACME External Account Binding (EAB) credentials specifically for custom-domain certificates, in addition to the existing EAB credentials. This includes extending CLI options, updating configuration structures, handling secrets, and updating the GCP bootstrapper and related tests to support this new functionality.
Related PR
Clickup