Repository navigation
Require WinFsp 2.2.26286 and offer to install it at startup - #253
Merged
Merged
Conversation
Bump WinFsp to 2026 Beta5 (2.2.26286) in the NuGet package, installer and CI. At startup the app now compares the installed winfsp-msil.dll with the required version. A missing runtime or an older one offers to install the MSI: it is taken from the portable ZIP's prerequisites folder or downloaded, verified against a pinned SHA256 through a handle kept open during the run, then executed elevated with msiexec. A newer WinFsp is accepted, and a declined or failed update of an older one is remembered per installed and required version. Only a missing runtime is fatal. The Inno Setup installer now replaces an older WinFsp with its bundled MSI, and the portable ZIP carries the MSI.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2.2.26286) inwinfsp.net, the Inno Setup installer, CI and docs.winfsp-msil.dllwith the required version instead of only checking for2.2.x.AppConfiguration.SkippedWinFspVersion).WinFspInstallertakes the MSI from the portable ZIP'sprerequisites\folder or downloads it, verifies a pinned SHA256 through a handle that stays open while elevatedmsiexecruns (no swap between check and run), and maps exit codes (success, reboot required, UAC declined, failure). Downloads are capped andmsiexechas a timeout.Test plan
dotnet buildanddotnet test tests/ManagedDrive.Tests(newWinFspPrerequisiteTests/WinFspInstallerTests)msiexec /aruns normally while the MSI is held open read-shared, and that the pinned SHA256 matches the Beta5 MSIinstaller/ManagedDrive.isswithiscc(not available locally) and run the release workflowKnown gaps
🤖 Generated with Claude Code