Repository navigation
Validate CLI options, enable warnings-as-errors, and note --top truncation - #79
Merged
Merged
Conversation
WarningsAsErrors=true was a no-op, since the property takes a list of warning codes.
…clude-lang names An out-of-range numeric --format silently rendered a table, and a misspelled language name produced an empty result with exit code 0. Both now fail with exit code 1 before the analysis runs.
The package description said 44 and CLAUDE.md said 58; the registry defines 66.
The Total row covers every language, so a --top table looked inconsistent. Table, Markdown, and Html now add a "Showing top N of M languages" note, and Json records languageCount next to byLanguageTruncated. Csv stays note-free to keep fixed columns.
A # line inside a multi-line string, heredoc, or awk script is counted as a comment; spanning lines would let one unbalanced quote swallow the rest of the file.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WarningsAsErrors=truewas a no-op (the property takes a list of warning codes); useTreatWarningsAsErrors. Verified a clean Release build and awin-x64trimmed single-file publish with no warnings.--format(it silently rendered a table) and unknown--include-lang/--exclude-langnames (they produced an empty result with exit code 0). Both now exit with code 1.Otheris accepted, matching--all.--top, the Total row still covers every language, which looked inconsistent. Table, Markdown and Html now add a "Showing top N of M languages" note; Json recordslanguageCountnext tobyLanguageTruncated; Csv stays note-free to keep fixed columns.Behavior changes
--formatvalue now fails with exit code 1 instead of succeeding. Scripts relying on the old behavior are affected.TreatWarningsAsErrorsnow applies to all projects, including the trimmed publish. NuGet audit warnings (NU1901-NU1904) would also fail the build; considerWarningsNotAsErrorsfor them if that is undesirable.Test plan
dotnet test Sloc.slnx(820 tests passing)dotnet publish -c Release -r win-x64with no warnings, and a smoke run of the published exe