PFM-ISSUE-34453 - github-actions: Normalize package-lock.json resolved URLs onto the JFrog npm proxy (release/25.2)

.github/actions/use-npmrc/action.yml

@@ -1,5 +1,5 @@
 name: 'Use .npmrc'
-description: 'Writes the given .npmrc content to ~/.npmrc'
+description: 'Writes the given .npmrc content to ~/.npmrc and warns about lockfile entries outside the cplace npm proxy'
 inputs:
   dot-npmrc:
     description: 'Content of the .npmrc file'
@@ -11,4 +11,31 @@ runs:
       shell: bash
       env:
         DOT_NPMRC: ${{ inputs.dot-npmrc }}
-      run: echo "$DOT_NPMRC" > ~/.npmrc
+      run: |
+        echo "$DOT_NPMRC" > ~/.npmrc
+        # PFM-ISSUE-34453 mitigation. npm's default `replace-registry-host=npmjs`
+        # rewrites a lockfile's registry.npmjs.org URLs onto the configured
+        # registry and DROPS that registry's path prefix, producing an E404 that
+        # is masked as *** because the prefix is the JFROG_URL secret.
+        # `never` makes npm fetch each `resolved` URL verbatim instead.
+        #
+        # This is a no-op on a lockfile that already resolves entirely through
+        # the proxy, so it is safe to leave in place, and it is removable once
+        # the warning below stops firing anywhere.
+        echo 'replace-registry-host=never' >> ~/.npmrc
+
+    - name: Warn on lockfile entries outside the cplace npm proxy
+      shell: bash
+      # Advisory only - never fails the build. The warnings are the inventory of
+      # lockfiles that still need normalizing; when none report, the mitigation
+      # above can be dropped.
+      #
+      # Invoked as `bash "<path>" || true`, not as a bare path. The script's own
+      # "every precondition is a silent success" contract cannot cover NOT BEING
+      # REACHABLE - a missing exec bit after checkout, a path containing spaces,
+      # or a runner where action_path is a backslashed Windows path. That is an
+      # exit 127 from the shell rather than from the script, and it would fail
+      # the consumer's job before `npm ci` in all seven workflows using this
+      # action. `continue-on-error:` is not honoured on composite steps, so
+      # `|| true` is the mechanism that actually works here.
+      run: bash "$GITHUB_ACTION_PATH/../../../tools/scripts/lockfile/warn-foreign-registry.sh" || true

.github/workflows/pr-checks.yml

@@ -0,0 +1,61 @@
+name: PR Checks
+
+# This repository's first `on: pull_request` workflow. Everything under
+# .github/workflows/ is otherwise `workflow_call`-only, and the `pull_request`
+# trigger lives in .github/workflow-templates/fe/fe-pr.yml, which GitHub never
+# executes.
+#
+# No `paths:` filter on purpose: a path-filtered workflow reports as pending
+# rather than success, and would permanently block merges once it becomes a
+# required check.
+on:
+  pull_request:
+    branches:
+      - '**'
+
+permissions:
+  contents: read
+
+jobs:
+  lockfile:
+    name: Lockfile registry invariant
+    runs-on: ${{ vars.SMALL_RUNNER || 'ubuntu-latest' }}
+    steps:
+      - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
+
+      # --prefix-only, NOT a baseline comparison. The ongoing guard must answer
+      # only "does every entry resolve via the proxy?" - a pull request has to
+      # stay free to add, remove or update dependencies.
+      #
+      # Comparing against the base branch would fail every legitimate dependency
+      # change, and would then advise running the normalizer, which cannot fix a
+      # graph difference. Graph invariance belongs to verifying a normalization
+      # commit (`--baseline HEAD~1`), not to everyday pull requests.
+      #
+      # With no baseline there is nothing to fetch, so the default shallow
+      # checkout is enough. jq is pre-installed on GitHub-hosted ubuntu runners,
+      # and this job runs no node and no `npm ci` - the guard has to be
+      # trustworthy precisely when the lockfile is broken.
+      - name: Check package-lock.json resolved URLs
+        run: ./tools/scripts/lockfile/check-lockfile.sh --prefix-only
+
+  scripts:
+    name: Shell scripts
+    runs-on: ${{ vars.SMALL_RUNNER || 'ubuntu-latest' }}
+    steps:
+      - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
+
+      # Never npm devDependencies: adding them would mutate package-lock.json on
+      # all seven branches and break the invariant this workflow exists to guard.
+      # shellcheck ships in the ubuntu image, but is installed here anyway so the
+      # job does not silently depend on image contents.
+      - name: Install bats and shellcheck
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y bats shellcheck
+
+      - name: shellcheck
+        run: shellcheck tools/scripts/lockfile/*.sh tools/scripts/lockfile/test-helper.bash
+
+      - name: bats
+        run: bats tools/scripts/lockfile/

.prettierignore

@@ -1,2 +1,3 @@
 node_modules
 .idea
+package-lock.json